Sign upLogin

SergiX44/XBackBone

View on GitHub
Star
app/Controllers/Auth/LoginController.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function ldapLogin has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function ldapLogin(Request $request, string $username, string $password, $dbUser)
    {
        // Build LDAP connection
        $server = $this->ldapConnect();
        if (!$server) {
Severity: Minor
Found in app/Controllers/Auth/LoginController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ldapLogin has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function ldapLogin(Request $request, string $username, string $password, $dbUser)
    {
        // Build LDAP connection
        $server = $this->ldapConnect();
        if (!$server) {
Severity: Minor
Found in app/Controllers/Auth/LoginController.php - About 1 hr to fix

    Method login has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function login(Request $request, Response $response): Response
    {
        /** @var ValidationHelper $validator */
        $validator = make(ValidationHelper::class);
    Severity: Minor
    Found in app/Controllers/Auth/LoginController.php - About 1 hr to fix

      Function login has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function login(Request $request, Response $response): Response
    {
        /** @var ValidationHelper $validator */
        $validator = make(ValidationHelper::class);
      Severity: Minor
      Found in app/Controllers/Auth/LoginController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status