SergiX44/XBackBone

View on GitHub
app/Database/Repositories/MediaRepository.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function runWithFileSort has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function runWithFileSort(int $page): MediaRepository
    {
        $this->storage->addPlugin(new ListWith());

        if ($this->isAdmin) {
Severity: Minor
Found in app/Database/Repositories/MediaRepository.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runWithFileSort has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function runWithFileSort(int $page): MediaRepository
    {
        $this->storage->addPlugin(new ListWith());

        if ($this->isAdmin) {
Severity: Major
Found in app/Database/Repositories/MediaRepository.php - About 2 hrs to fix

    Method runWithDbSort has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function runWithDbSort(int $page): MediaRepository
        {
            $params = [];
            if ($this->isAdmin) {
                [$queryMedia, $queryPages] = $this->buildAdminQueries();
    Severity: Minor
    Found in app/Database/Repositories/MediaRepository.php - About 1 hr to fix

      Function runWithDbSort has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function runWithDbSort(int $page): MediaRepository
          {
              $params = [];
              if ($this->isAdmin) {
                  [$queryMedia, $queryPages] = $this->buildAdminQueries();
      Severity: Minor
      Found in app/Database/Repositories/MediaRepository.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildAdminQueries has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function buildAdminQueries()
          {
              $queryPages = 'SELECT COUNT(*) AS `count` FROM `uploads`';
              $queryMedia = 'SELECT `uploads`.*, `users`.`user_code`, `users`.`username` FROM `uploads` LEFT JOIN `users` ON `uploads`.`user_id` = `users`.`id`';
      
      
      Severity: Minor
      Found in app/Database/Repositories/MediaRepository.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status