SergioMadness/payment-laravel

Payment has 43 functions (exceeds 20 allowed). Consider refactoring.

Open

class Payment implements PaymentFacade
{
    /**
     * Available drivers
     *

Method getPaymentForm has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function getPaymentForm($orderId,
                                   $paymentId,
                                   float $amount,
                                   string $currency = self::CURRENCY_RUR,
                                   string $paymentType = self::PAYMENT_TYPE_CARD,

Method getPaymentLink has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function getPaymentLink($orderId,
                                   $paymentId,
                                   float $amount,
                                   string $currency = self::CURRENCY_RUR,
                                   string $paymentType = self::PAYMENT_TYPE_CARD,

Method getPaymentForm has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function getPaymentForm($orderId,
                                   $paymentId,
                                   float $amount,
                                   string $currency = self::CURRENCY_RUR,
                                   string $paymentType = self::PAYMENT_TYPE_CARD,

Method getPaymentLink has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function getPaymentLink($orderId,
                                   $paymentId,
                                   float $amount,
                                   string $currency = self::CURRENCY_RUR,
                                   string $paymentType = self::PAYMENT_TYPE_CARD,

Method initPayment has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function initPayment(string $token, string $orderId, string $paymentId, float $amount, string $description, string $currency = PayService::CURRENCY_RUR_ISO, array $extraParams = []): bool;

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function setAccountId(string $id): self;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function approveTransaction($id): bool;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function getSchedule(string $id): RecurringSchedule;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function getTransactionStatus($id): string;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

    public function setUserId(string $id): self;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function __construct(string $name = null, int $qty = null, float $price = null, int $tax = null, string $currency = 'RUR')

Multi-line function declaration not indented correctly; expected 8 spaces but found 35

Open

                                   array $extraParams = [],

• Exclude checks
  • Disable engine
  • Disable check

The closing parenthesis of a multi-line function declaration must be on a new line

Open

                                   Receipt $receipt = null): string;

• Exclude checks
  • Disable engine
  • Disable check

The closing parenthesis of a multi-line function declaration must be on a new line

Open

                                   Receipt $receipt = null): Form

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function declaration not indented correctly; expected 8 spaces but found 35

Open

                                   string $description = '',

• Exclude checks
  • Disable engine
  • Disable check

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line

Open

    {

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function declaration not indented correctly; expected 8 spaces but found 35

Open

                                   string $failReturnUrl = '',

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function declaration not indented correctly; expected 8 spaces but found 35

Open

                                   string $currency = self::CURRENCY_RUR,

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function declaration not indented correctly; expected 8 spaces but found 35

Open

                                   string $failReturnUrl = '',

• Exclude checks
  • Disable engine
  • Disable check