Function recursiveArraySearch
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public static function recursiveArraySearch($needleKey, $needleValue,
array $haystack)
{
foreach ($haystack as $key => $value) {
$currentKey = $key;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused local variables such as '$key'. Open
foreach ($haystack as $key => &$value) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$key'. Open
foreach ($haystack as $key => &$value) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method groupArray uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$result[$id] = array($data);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method map uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$result[] = $item[$valueKey];
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid variables with short names like $id. Configured minimum length is 3. Open
$id = $data[$groupField];
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $o. Configured minimum length is 3. Open
public static function toArray($o)
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Multi-line function declaration not indented correctly; expected 8 spaces but found 48 Open
array $haystack)
- Exclude checks
Multi-line function declarations must define one parameter per line Open
public static function recursivelySetValue($needleKey, $needleValue,
- Exclude checks
The first parameter of a multi-line function declaration must be on the line after the opening bracket Open
public static function recursiveArraySearch($needleKey, $needleValue,
- Exclude checks
The closing parenthesis of a multi-line function declaration must be on a new line Open
array &$haystack)
- Exclude checks
Multi-line function declaration not indented correctly; expected 8 spaces but found 47 Open
array &$haystack)
- Exclude checks
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{
- Exclude checks
Multi-line function declarations must define one parameter per line Open
public static function recursiveArraySearch($needleKey, $needleValue,
- Exclude checks
The first parameter of a multi-line function declaration must be on the line after the opening bracket Open
public static function recursivelySetValue($needleKey, $needleValue,
- Exclude checks
The closing parenthesis of a multi-line function declaration must be on a new line Open
array $haystack)
- Exclude checks
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{
- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$needleValue, $value) !== false)) {
- Exclude checks
Expected 1 newline at end of file; 0 found Open
}
- Exclude checks
Closing parenthesis of a multi-line function call must be on a line by itself Open
$needleValue, $value) !== false)) {
- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
== $value)) || ( is_array($value) && self::recursiveArraySearch($needleKey,
- Exclude checks
Multi-line function call not indented correctly; expected 16 spaces but found 20 Open
$needleValue, $value) !== false)) {
- Exclude checks