SergioMadness/pwf-helpers

View on GitHub
src/Validator.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '97', column '23').
Open

            throw new \Exception('Parameter is not set');
Severity: Minor
Found in src/Validator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '69', column '23').
Open

            throw new \Exception('Parameter is not set');
Severity: Minor
Found in src/Validator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '145', column '23').
Open

            throw new \Exception('Callback parameter is required');
Severity: Minor
Found in src/Validator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '125', column '23').
Open

            throw new \Exception('Parameter is not set');
Severity: Minor
Found in src/Validator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '50', column '27').
Open

                throw new \Exception('Unknown validator');
Severity: Minor
Found in src/Validator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '72', column '23').
Open

            throw new \Exception('Parameter \'equalTo\' is required');
Severity: Minor
Found in src/Validator.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method validateByCallback uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            throw new \Exception('Callback parameter is required');
        }
Severity: Minor
Found in src/Validator.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method validateEmail uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            throw new \Exception('Parameter is not set');
        }
Severity: Minor
Found in src/Validator.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Multi-line function declarations must define one parameter per line
Open

    public static function validateLength($paramName, array $data,
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The closing parenthesis of a multi-line function declaration must be on a new line
Open

                                            array $params = [])
Severity: Minor
Found in src/Validator.php by phpcodesniffer

Multi-line function declarations must define one parameter per line
Open

    public static function validateEquality($paramName, array $data,
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The first parameter of a multi-line function declaration must be on the line after the opening bracket
Open

    public static function validateLength($paramName, array $data,
Severity: Minor
Found in src/Validator.php by phpcodesniffer

Multi-line function declaration not indented correctly; expected 8 spaces but found 44
Open

                                            array $params = [])
Severity: Minor
Found in src/Validator.php by phpcodesniffer

Multi-line function declaration not indented correctly; expected 8 spaces but found 42
Open

                                          array $params = [])
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The first parameter of a multi-line function declaration must be on the line after the opening bracket
Open

    public static function validateEquality($paramName, array $data,
Severity: Minor
Found in src/Validator.php by phpcodesniffer

Multi-line function declaration not indented correctly; expected 8 spaces but found 46
Open

                                              array $params)
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The closing parenthesis of a multi-line function declaration must be on a new line
Open

                                              array $params)
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The closing parenthesis of a multi-line function declaration must be on a new line
Open

                                          array $params = [])
Severity: Minor
Found in src/Validator.php by phpcodesniffer

The first parameter of a multi-line function declaration must be on the line after the opening bracket
Open

    public static function validateByCallback($paramName, array $data,
Severity: Minor
Found in src/Validator.php by phpcodesniffer

Multi-line function declarations must define one parameter per line
Open

    public static function validateByCallback($paramName, array $data,
Severity: Minor
Found in src/Validator.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/Validator.php by phpcodesniffer

There are no issues that match your filters.

Category
Status