framework/components/authorization/Authorization.php
The method setIdentity has a boolean flag argument $remember, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function setIdentity(Identity $user, $remember = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Only one argument is allowed per line in a multi-line function call Open
Open
$remember ? time() + 365 * 24 * 60 * 60 : null, '/');- Exclude checks
Whitespace found at end of line Open
Open
* - Exclude checks
Multi-line function call not indented correctly; expected 8 spaces but found 12 Open
Open
$remember ? time() + 365 * 24 * 60 * 60 : null, '/');- Exclude checks
Closing parenthesis of a multi-line function call must be on a line by itself Open
Open
$remember ? time() + 365 * 24 * 60 * 60 : null, '/');- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
Open
Application::$instance->getResponse()->addCookie(self::TOKEN_NAME,- Exclude checks
Expected 1 newline at end of file; 0 found Open
Open
}- Exclude checks