Sign upLogin

SergioMadness/query-builder

View on GitHub
Star
src/adapters/MySQL/SelectBuilder.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '87', column '14').
Open

    protected function buildLimit()
    {
        $result = '';

        if (($offset = $this->getOffset()) > 0) {
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '90', column '14').
Open

    protected function buildLimit()
    {
        $result = '';

        if (($offset = $this->getOffset()) > 0) {
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Expected 1 space after FUNCTION keyword; 0 found
Open

            function(&$value, $key) {
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Line indented incorrectly; expected at least 20 spaces, found 16
Open

                $value = $key.' AS '.$value;
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Line indented incorrectly; expected 16 spaces, found 12
Open

            }
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Line indented incorrectly; expected 12 spaces, found 8
Open

        });
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

        });
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

        array_walk($fields,
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Line indented incorrectly; expected 16 spaces, found 12
Open

            if (is_string($key)) {
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Closing brace indented incorrectly; expected 12 spaces, found 8
Open

        });
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/adapters/MySQL/SelectBuilder.php by phpcodesniffer

There are no issues that match your filters.

Category
Status