Sign upLogin

SergioMadness/query-builder

View on GitHub
Star
src/adapters/SQL/ConditionBuilder.php

Summary

Maintainability
A
1 hr
Test Coverage

Method prepareArray has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepareArray(array $conditions)
    {
        switch (count($conditions)) {
            case 1:
                $result = $conditions[0];
Severity: Minor
Found in src/adapters/SQL/ConditionBuilder.php - About 1 hr to fix

    Function prepareArray has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function prepareArray(array $conditions)
    {
        switch (count($conditions)) {
            case 1:
                $result = $conditions[0];
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '45', column '27').
    Open

                    throw new \Exception('Wrong condition configuration');
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method prepareArray uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $result = $conditions[0].'=?';//.$conditions[0];
                    $this->addParam($conditions[0], $conditions[1]);
                }
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Expected 1 newline at end of file; 0 found
    Open

    }
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php by phpcodesniffer

    Closing parenthesis of a multi-line function call must be on a line by itself
    Open

                                $conditions[1]->getParams()));
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php by phpcodesniffer

    Multi-line function call not indented correctly; expected 20 spaces but found 28
    Open

                                $conditions[1]->getParams()));
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php by phpcodesniffer

    Opening parenthesis of a multi-line function call must be the last content on the line
    Open

                        $this->setParams(array_merge($this->getParams(),
    Severity: Minor
    Found in src/adapters/SQL/ConditionBuilder.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status