Sign upLogin

SeunAdelekan/Kanary

View on GitHub
Star

Showing 77 of 77 total issues

Method resolveTargetRoute has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

    /**
     * Method used for route resolution
     * @param method HTTP method of the request
     * @param target Target resource
     * @return route required to handle HTTP request
Severity: Minor
Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        (0..cweets.size-1).forEach { i ->
            val cweetNode = mapper.createObjectNode()
            with(cweetNode){
                put("cweet_id", cweets[i].cweetId)
                put("user_id", cweets[i].creatorId)
Severity: Major
Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 4 hrs to fix
examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 197..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 292.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            (0..cweets.size-1).forEach { i ->
                val cweetNode = mapper.createObjectNode()
                with(cweetNode){
                    put("cweet_id", cweets[i].cweetId)
                    put("user_id", cweets[i].creatorId)
Severity: Major
Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt and 1 other location - About 4 hrs to fix
examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt on lines 117..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 292.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Class AppRouter has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

/**
 * @author Iyanu Adelekan on 16/08/2018.
 *
 * Core application router class. Utilize instances of this class
 * to compose server routes. Upon composition of a route it must be
Severity: Minor
Found in src/main/com/iyanuadelekan/kanary/app/router/AppRouter.kt - About 2 hrs to fix

    Method fetchUserFeed has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        fun fetchUserFeed(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
    Severity: Major
    Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 2 hrs to fix

      Class Router has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      /**
 * @author Iyanu Adelekan on 16/08/2018.
 *
 * Interface defining methods that must be implemented by an application router.
 */
      Severity: Minor
      Found in src/main/com/iyanuadelekan/kanary/app/framework/router/Router.kt - About 2 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        val requestLogger: (HttpServletRequest?) -> Unit = {
    if(it != null && it.method != null && it.pathInfo != null) {
        println("Started ${it.scheme} ${it.method} request to: '${it.pathInfo}'")
    }
}
        Severity: Major
        Found in examples/HelloWorld - Gradle/src/hello/world/app.kt and 1 other location - About 2 hrs to fix
        examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/app.kt on lines 11..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        val requestLogger: (HttpServletRequest?) -> Unit = {
    if(it != null && it.method != null && it.pathInfo != null) {
        println("Started ${it.scheme} ${it.method} request to: '${it.pathInfo}'")
    }
}
        Severity: Major
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/app.kt and 1 other location - About 2 hrs to fix
        examples/HelloWorld - Gradle/src/hello/world/app.kt on lines 18..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method addRoute has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
        Open

            /**
     * Invoked to register a new route to the router.
     *
     * @param routeType - type of route to be added. See [RouteType].
     * @param path - URL path.
        Severity: Minor
        Found in src/main/com/iyanuadelekan/kanary/app/router/RouteManager.kt - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method userSignUp has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            fun userSignUp(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
        Severity: Minor
        Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt - About 1 hr to fix

          Method resolveTargetRoute has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              /**
     * Method used for route resolution
     * @param method HTTP method of the request
     * @param target Target resource
     * @return route required to handle HTTP request
          Severity: Minor
          Found in src/main/com/iyanuadelekan/kanary/handlers/AppHandler.kt - About 1 hr to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                /**
     * Router function handling GET requests
     * @param path Specified route path
     * @param action Action to handle requests targeting specified route path
     * @param controller Controller handling the route
            Severity: Major
            Found in src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt and 5 other locations - About 1 hr to fix
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 41..51
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 53..63
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 65..75
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 77..87
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 89..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                /**
     * Router function handling PUT requests
     * @param path Specified route path
     * @param action Action to handle requests targeting specified route path
     * @param controller Controller handling the route
            Severity: Major
            Found in src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt and 5 other locations - About 1 hr to fix
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 29..39
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 41..51
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 53..63
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 77..87
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 89..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                /**
     * Router function handling POST requests
     * @param path Specified route path
     * @param action Action to handle requests targeting specified route path
     * @param controller Controller handling the route
            Severity: Major
            Found in src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt and 5 other locations - About 1 hr to fix
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 29..39
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 53..63
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 65..75
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 77..87
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 89..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                /**
     * Router function handling PATCH requests
     * @param path Specified route path
     * @param action Action to handle requests targeting specified route path
     * @param controller Controller handling the route
            Severity: Major
            Found in src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt and 5 other locations - About 1 hr to fix
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 29..39
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 41..51
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 53..63
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 65..75
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 77..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                /**
     * Router function handling DELETE requests
     * @param path Specified route path
     * @param action Action to handle requests targeting specified route path
     * @param controller Controller handling the route
            Severity: Major
            Found in src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt and 5 other locations - About 1 hr to fix
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 29..39
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 41..51
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 65..75
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 77..87
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 89..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                /**
     * Router function handling PATCH requests
     * @param path Specified route path
     * @param action Action to handle requests targeting specified route path
     * @param controller Controller handling the route
            Severity: Major
            Found in src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt and 5 other locations - About 1 hr to fix
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 29..39
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 41..51
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 53..63
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 65..75
            src/main/com/iyanuadelekan/kanary/core/KanaryRouter.kt on lines 89..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method userSignUp has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
            Open

                fun userSignUp(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
            Severity: Minor
            Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/auth.kt - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetchFeed has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                fun fetchFeed(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
            Severity: Minor
            Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 1 hr to fix

              Method createCweet has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  fun createCweet(baseRequest: Request, request: HttpServletRequest, response: HttpServletResponse) {
        // Create json object mapper
        val mapper = ObjectMapper()
        val responseRootNode = mapper.createObjectNode()
              Severity: Minor
              Found in examples/Kanary-Mini-Twitter-Clone/src/curious/cwitter/timeline.kt - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language