Sign upLogin

SeunAdelekan/PaystackJava

View on GitHub
Star

Showing 28 of 28 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public JSONObject listPlans(String perPage, String page) {
        this.apiConnection = new ApiConnection(Definitions.PAYSTACK_PLANS_LIST_PLANS);
        ApiQuery apiQuery = new ApiQuery();

        apiQuery.putParams("perPage", perPage);
Severity: Major
Found in src/me/iyanuadelekan/paystackjava/core/Plans.java and 2 other locations - About 45 mins to fix
src/me/iyanuadelekan/paystackjava/core/Customers.java on lines 90..98
src/me/iyanuadelekan/paystackjava/core/Transactions.java on lines 100..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public JSONObject listTransactions(String perPage, String page) {
        this.apiConnection = new ApiConnection(Definitions.PAYSTACK_TRANSACTIONS_LIST_TRANSACTIONS);
        ApiQuery apiQuery = new ApiQuery();
        apiQuery.putParams("perPage", perPage);
        apiQuery.putParams("page", page);
Severity: Major
Found in src/me/iyanuadelekan/paystackjava/core/Transactions.java and 2 other locations - About 45 mins to fix
src/me/iyanuadelekan/paystackjava/core/Customers.java on lines 90..98
src/me/iyanuadelekan/paystackjava/core/Plans.java on lines 93..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method updateCustomer has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public JSONObject updateCustomer(String idOrCustomerCode, String email, String firstName, String lastName,
            String phone, Object metadata) {
Severity: Minor
Found in src/me/iyanuadelekan/paystackjava/core/Customers.java - About 45 mins to fix

    Method paystackStandard has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public JSONObject paystackStandard(String reference, int amount, String email, String plan, String callback_url) {
    Severity: Minor
    Found in src/me/iyanuadelekan/paystackjava/core/PaystackInline.java - About 35 mins to fix

      Method createCustomer has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public JSONObject createCustomer(String email, String firstName, String lastName,
            String phone, Object metadata) {
      Severity: Minor
      Found in src/me/iyanuadelekan/paystackjava/core/Customers.java - About 35 mins to fix

        Method updatePage has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public JSONObject updatePage(String idOrSlug, String name, String description, String amount, boolean active) {
        Severity: Minor
        Found in src/me/iyanuadelekan/paystackjava/core/Pages.java - About 35 mins to fix

          Method chargeAuthorization has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public JSONObject chargeAuthorization(String reference, String authorization_code, String amount,
            String email, String callback_url) {
          Severity: Minor
          Found in src/me/iyanuadelekan/paystackjava/core/Transactions.java - About 35 mins to fix

            Method initializeTransaction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public JSONObject initializeTransaction(String reference, String amount, String email,
            String plan, String callback_url) {
            Severity: Minor
            Found in src/me/iyanuadelekan/paystackjava/core/Transactions.java - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language