Sign upLogin

SeunAdelekan/PaystackJava

View on GitHub
Star
src/me/iyanuadelekan/paystackjava/core/Customers.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method updateCustomer has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public JSONObject updateCustomer(String idOrCustomerCode, String email, String firstName, String lastName,
            String phone, Object metadata) {
Severity: Minor
Found in src/me/iyanuadelekan/paystackjava/core/Customers.java - About 45 mins to fix

    Method createCustomer has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public JSONObject createCustomer(String email, String firstName, String lastName,
            String phone, Object metadata) {
    Severity: Minor
    Found in src/me/iyanuadelekan/paystackjava/core/Customers.java - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public JSONObject createCustomer(String email, String firstName, String lastName,
            String phone, Object metadata) {
        this.apiConnection = new ApiConnection(Definitions.PAYSTACK_CUSTOMERS_CREATE_CUSTOMER);
        ApiQuery apiQuery = new ApiQuery();
      Severity: Major
      Found in src/me/iyanuadelekan/paystackjava/core/Customers.java and 2 other locations - About 1 hr to fix
      src/me/iyanuadelekan/paystackjava/core/Transactions.java on lines 48..58
      src/me/iyanuadelekan/paystackjava/core/Transactions.java on lines 151..163

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public JSONObject listCustomers(int perPage, int page) {
        this.apiConnection = new ApiConnection(Definitions.PAYSTACK_CUSTOMERS_LIST_CUSTOMERS);

        ApiQuery apiQuery = new ApiQuery();
        apiQuery.putParams("perPage", perPage);
      Severity: Major
      Found in src/me/iyanuadelekan/paystackjava/core/Customers.java and 2 other locations - About 45 mins to fix
      src/me/iyanuadelekan/paystackjava/core/Plans.java on lines 93..101
      src/me/iyanuadelekan/paystackjava/core/Transactions.java on lines 100..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status