Sign upLogin

Shemplo/Neerc-chat-client

View on GitHub
Star
src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java

Summary

Maintainability
D
1 day
Test Coverage

Method onUsersUpdated has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void onUsersUpdated () {
        SceneComponent.USERS_H.<HBox> safe (holder.getScene ())
                      .ifPresent (line -> {
            Platform.runLater (line.getChildren ()::clear);
Severity: Minor
Found in src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java - About 1 hr to fix

    Method onUserChangedPresence has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public void onUserChangedPresence (String user, OnlineStatus status) {
        Image image = Stream.of (status)
                . map (OnlineStatus::name)
                . map (String::toLowerCase)
    Severity: Minor
    Found in src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              SceneComponent.USERS_V.<VBox> safe (holder.getScene ()).ifPresent (line -> {
            Platform.runLater (line.getChildren ()::clear);
            
            final UsersService usersService = holder.getManager ().getUsersService ();
            List <Button> buttons = usersService.getUsers ().stream ().sorted (UE_COMPARATOR)
      Severity: Major
      Found in src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java and 1 other location - About 4 hrs to fix
      src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java on lines 85..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 252.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              SceneComponent.USERS_H.<HBox> safe (holder.getScene ())
                      .ifPresent (line -> {
            Platform.runLater (line.getChildren ()::clear);
            
            final UsersService usersService = holder.getManager ().getUsersService ();
      Severity: Major
      Found in src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java and 1 other location - About 4 hrs to fix
      src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java on lines 111..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 252.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              SceneComponent.USERS_H.<HBox> safe (holder.getScene ())
                      .ifPresent (line -> {
            Platform.runLater (() -> {
                line.getChildren ().stream ()
                    .map       (o -> (Button) o)
      Severity: Major
      Found in src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java and 1 other location - About 1 hr to fix
      src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java on lines 58..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              SceneComponent.USERS_V.<VBox> safe (holder.getScene ())
                      .ifPresent (line -> {
            Platform.runLater (() -> {
              line.getChildren ().stream ()
                  .map       (o -> (Button) o)
      Severity: Major
      Found in src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java and 1 other location - About 1 hr to fix
      src/main/java/ru/shemplo/chat/neerc/gfx/scenes/MainSceneListener.java on lines 48..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status