ShogunPanda/lazier

View on GitHub
lib/lazier/timezone.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method to_str_unparameterized has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def to_str_unparameterized(dst_label, label, offset_label, offset_position, utc_label, with_offset)
Severity: Minor
Found in lib/lazier/timezone.rb - About 45 mins to fix

    Method dst_period has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def dst_period(year = nil)
          year ||= ::Date.current.year
    
          period = period_for_utc(::DateTime.civil(year, 7, 15, 12).utc) # Summer for the northern hemisphere
          period = period_for_utc(::DateTime.civil(year, 1, 15, 12).utc) unless period.dst? # Summer for the southern hemisphere
    Severity: Minor
    Found in lib/lazier/timezone.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def list(with_dst = true, dst_label: " (DST)", parameterized: false, sort_by_name: true, as_hash: false)
            dst_label = nil unless with_dst
            key = [dst_label, sort_by_name, as_hash, parameterized].join(":")
            @zones_names ||= {}
    
    
    Severity: Minor
    Found in lib/lazier/timezone.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parameterize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def parameterize(tz, with_offset = true)
            tz = tz.to_str unless tz.is_a?(::String)
    
            if tz =~ ::Lazier::TimeZone::ALREADY_PARAMETERIZED
              tz
    Severity: Minor
    Found in lib/lazier/timezone.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method offset has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def offset(rational: false, dst: false, year: nil)
          rv =
            if dst
              period = dst_period(year)
              period ? period.utc_total_offset : 0
    Severity: Minor
    Found in lib/lazier/timezone.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_str has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_str(dst = false, **args)
          # PI: Ignore reek on this.
          label, dst_label, utc_label, year, parameterized, with_offset, colon, offset_position = prepare_to_str_arguments(args)
    
          if parameterized
    Severity: Minor
    Found in lib/lazier/timezone.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status