Sign upLogin

Shoobx/shoobx.rml2odt

View on GitHub
Star

Showing 48 of 48 total issues

Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def process(self):
        self._convertSimpleContent()

        parent_style = self.parent.getRootStyle()
        fancy_numbering = getattr(parent_style, 'fancy_numbering', False)
Severity: Minor
Found in src/shoobx/rml2odt/list.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _executeCommand has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def _executeCommand(self, stylemap, tagname, styleCommand):
        attrs = styleCommand.getStyleProps()

        try:
            # let's first see tags which need special handling
Severity: Minor
Found in src/shoobx/rml2odt/table.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function inputImageIntoCell has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def inputImageIntoCell(self):
        manager = attr.getManager(self)
        paraStyleName = manager.getNextStyleName('ImagePara')
        paraStyle = odf.style.Style(
            family='paragraph',
Severity: Minor
Found in src/shoobx/rml2odt/flowable.py - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            cols = sorted([col if col >= 0 else self.columns+col
                       for col in [start_col, end_col]])
    Severity: Major
    Found in src/shoobx/rml2odt/table.py and 1 other location - About 1 hr to fix
    src/shoobx/rml2odt/table.py on lines 279..280

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            rows = sorted([row if row >= 0 else self.rows+row
                       for row in [start_row, end_row]])
    Severity: Major
    Found in src/shoobx/rml2odt/table.py and 1 other location - About 1 hr to fix
    src/shoobx/rml2odt/table.py on lines 277..278

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _doInnerGrid has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _doInnerGrid(self, stylemap, attrs):
        start_col, start_row, end_col, end_row = self._getStartEndPos(attrs)

        if start_row == end_row and start_col == end_col:
            return
    Severity: Minor
    Found in src/shoobx/rml2odt/table.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _applyAttributes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _applyAttributes(self, stylemap, attrs):
        start_col, start_row, end_col, end_row = self._getStartEndPos(attrs)

        for col in range(start_col, end_col+1):
            for row in range(start_row, end_row+1):
    Severity: Minor
    Found in src/shoobx/rml2odt/table.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function registerParagraphStyle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def registerParagraphStyle(doc, name, rmlStyle):
    if 'style.' in name:
        name = name[6:]

    odtStyle = odf.style.Style(name=name, family='paragraph')
    Severity: Minor
    Found in src/shoobx/rml2odt/stylesheet.py - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def _getNodeName(self, node):
        for att, value in node.attributes.items():
            if att[1] == 'name':
                return value
        return None
      Severity: Major
      Found in src/shoobx/rml2odt/template.py and 1 other location - About 1 hr to fix
      src/shoobx/rml2odt/list.py on lines 91..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def _getStartValue(self, node, default=0):
        for att, value in node.attributes.items():
            if att[1] == 'start-value':
                return value
        return default
      Severity: Major
      Found in src/shoobx/rml2odt/list.py and 1 other location - About 1 hr to fix
      src/shoobx/rml2odt/template.py on lines 90..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function process has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def process(self):
        # if we have a bulkData tag, let's have first TableBulkData
        # process the data by adding tr and td tags
        # XXX: might be simpler to grasp if this would be done here
        #      and we'd just drop the bulkData child tag
      Severity: Minor
      Found in src/shoobx/rml2odt/table.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _doZebraRows has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def _doZebraRows(self, stylemap, attrs):
        start_col, start_row, end_col, end_row = self._getStartEndPos(attrs)
        colors = attrs['cellProps']['backgroundcolors']
        for col in range(start_col, end_col+1):
            idx = 0
      Severity: Minor
      Found in src/shoobx/rml2odt/table.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getStyleMap has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def getStyleMap(self):
        # prepare a map of styles for each cell in the table
        stylemap = [
            [_styleCell()
             for r in range(self.rows)] for c in range(self.columns)]
      Severity: Minor
      Found in src/shoobx/rml2odt/table.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if 'bulletType' in attrs:
                            bulletType = attrs['bulletType']
                            levelstyle.setAttribute('numformat', bulletType)
      Severity: Major
      Found in src/shoobx/rml2odt/list.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if 'bulletFormat' in attrs:
                            bulletFormat = attrs['bulletFormat']
                            pre, post = bulletFormat.split('%s')
                            levelstyle.setAttribute('numprefix', pre)
                            levelstyle.setAttribute('numsuffix', post)
        Severity: Major
        Found in src/shoobx/rml2odt/list.py - About 45 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if 'value' in attrs:
            manager.colors[attrs['id']] = attrs['value']
          Severity: Major
          Found in src/shoobx/rml2odt/document.py and 2 other locations - About 45 mins to fix
          src/shoobx/rml2odt/document.py on lines 41..42
          src/shoobx/rml2odt/document.py on lines 43..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid deeply nested control flow statements.
          Open

                                  if aname.startswith(where):
                            aname = aname[len(where):]
                            odtname = self.lineAttributesMapping[aname]
                            borders[targetAttr][odtname] = avalue
          Severity: Major
          Found in src/shoobx/rml2odt/table.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if 'start' in attrs:
                            start = attrs['start']
                            if isinstance(start, int):
                                bulletType = None
                            else:
            Severity: Major
            Found in src/shoobx/rml2odt/list.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if dash[0] in (1, 2):
                        style = 'dotted'
                    elif dash[0] in (3, 4):
                        style = 'fine-dashed'
                    else:
              Severity: Major
              Found in src/shoobx/rml2odt/stylesheet.py - About 45 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if 'CMYK' in attrs:
            manager.colors[attrs['id']] = attrs['CMYK']
                Severity: Major
                Found in src/shoobx/rml2odt/document.py and 2 other locations - About 45 mins to fix
                src/shoobx/rml2odt/document.py on lines 39..40
                src/shoobx/rml2odt/document.py on lines 41..42

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language