Sign upLogin

Shopify/active_merchant

View on GitHub
Star
lib/active_merchant/billing/gateways/datatrans.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class DatatransGateway has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

    class DatatransGateway < Gateway
      self.test_url = 'https://api.sandbox.datatrans.com/v1/transactions/'
      self.live_url = 'https://api.datatrans.com/v1/transactions/'

      self.supported_countries = %w(CH GR US) # to confirm the countries supported.
Severity: Minor
Found in lib/active_merchant/billing/gateways/datatrans.rb - About 2 hrs to fix

    Method url has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def url(endpoint, options = {})
        case endpoint
        when 'settle', 'credit', 'cancel'
          "#{test? ? test_url : live_url}#{options[:transaction_id]}/#{endpoint}"
        else
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/datatrans.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_card has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def build_card(payment_method)
        if payment_method.is_a?(NetworkTokenizationCreditCard)
          {
            type: DEVICE_SOURCE[payment_method.source] ? 'DEVICE_TOKEN' : 'NETWORK_TOKEN',
            tokenType: DEVICE_SOURCE[payment_method.source] || CREDIT_CARD_SOURCE[card_brand(payment_method)],
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/datatrans.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method success_from has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def success_from(action, response)
        case action
        when 'authorize', 'credit'
          true if response.include?('transactionId') && response.include?('acquirerAuthorizationCode')
        when 'settle', 'cancel'
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/datatrans.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def parse(response)
        JSON.parse response
      rescue JSON::ParserError
        msg = 'Invalid JSON response received from Datatrans. Please contact them for support if you continue to receive this message.'
        msg += "  (The raw response returned by the API was #{response.inspect})"
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/datatrans.rb and 1 other location - About 20 mins to fix
    lib/active_merchant/billing/gateways/fat_zebra.rb on lines 226..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def capture(money, authorization, options = {})
        post = { refno: options.fetch(:order_id, '') }
        transaction_id = authorization.split('|').first
        add_currency_amount(post, money, options)
        commit('settle', post, { transaction_id: transaction_id })
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/datatrans.rb and 1 other location - About 15 mins to fix
    lib/active_merchant/billing/gateways/datatrans.rb on lines 54..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def refund(money, authorization, options = {})
        post = { refno: options.fetch(:order_id, '') }
        transaction_id = authorization.split('|').first
        add_currency_amount(post, money, options)
        commit('credit', post, { transaction_id: transaction_id })
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/datatrans.rb and 1 other location - About 15 mins to fix
    lib/active_merchant/billing/gateways/datatrans.rb on lines 47..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status