Sign upLogin

Shopify/active_merchant

View on GitHub
Star
lib/active_merchant/billing/gateways/quantum.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class QuantumGateway has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

    class QuantumGateway < Gateway
      self.live_url = self.test_url = 'https://secure.quantumgateway.com/cgi/xml_requester.php'

      # visa, master, american_express, discover
      self.supported_cardtypes = %i[visa master american_express discover]
Severity: Minor
Found in lib/active_merchant/billing/gateways/quantum.rb - About 3 hrs to fix

    Method add_address has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def add_address(xml, creditcard, address, options, shipTo = false)
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/quantum.rb - About 35 mins to fix

      Method parse_element has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse_element(reply, node)
        if node.has_elements?
          node.elements.each { |e| parse_element(reply, e) }
        else
          if /item/.match?(node.parent.name)
      Severity: Minor
      Found in lib/active_merchant/billing/gateways/quantum.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status