Sign upLogin

Shopify/active_merchant

View on GitHub
Star
lib/active_merchant/billing/gateways/realex.rb

Summary

Maintainability
C
1 day
Test Coverage

Class RealexGateway has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

    class RealexGateway < Gateway
      self.live_url = self.test_url = 'https://epage.payandshop.com/epage-remote.cgi'

      CARD_MAPPING = {
        'master'            => 'MC',
Severity: Minor
Found in lib/active_merchant/billing/gateways/realex.rb - About 4 hrs to fix

    File realex.rb has 327 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'nokogiri'
require 'digest/sha1'

module ActiveMerchant
  module Billing
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/realex.rb - About 3 hrs to fix

      Method add_address_and_customer_info has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

            def add_address_and_customer_info(xml, options)
        billing_address = options[:billing_address] || options[:address]
        shipping_address = options[:shipping_address]
        ipv4_address = ipv4?(options[:ip]) ? options[:ip] : nil
      Severity: Minor
      Found in lib/active_merchant/billing/gateways/realex.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse(xml)
        response = {}

        doc = Nokogiri::XML(xml)
        doc.xpath('//response/*').each do |node|
      Severity: Minor
      Found in lib/active_merchant/billing/gateways/realex.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status