Sign upLogin

Shopify/active_merchant

View on GitHub
Star
lib/active_merchant/billing/gateways/trust_commerce.rb

Summary

Maintainability
D
2 days
Test Coverage

Method add_addresses has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

      def add_addresses(params, options)
        address = options[:billing_address] || options[:address]

        if address
          params[:address1]  = address[:address1] unless address[:address1].blank?
Severity: Minor
Found in lib/active_merchant/billing/gateways/trust_commerce.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class TrustCommerceGateway has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

    class TrustCommerceGateway < Gateway
      self.live_url = self.test_url = 'https://vault.trustcommerce.com/trans/'

      SUCCESS_TYPES = %w[approved accepted]
Severity: Minor
Found in lib/active_merchant/billing/gateways/trust_commerce.rb - About 4 hrs to fix

    File trust_commerce.rb has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    begin
  require 'tclink'
rescue LoadError
  # Falls back to an SSL post to TrustCommerce
end
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/trust_commerce.rb - About 3 hrs to fix

      Method recurring has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def recurring(money, creditcard, options = {})
        ActiveMerchant.deprecated RECURRING_DEPRECATION_MESSAGE

        requires!(options, %i[periodicity bimonthly monthly biweekly weekly yearly daily])
      Severity: Minor
      Found in lib/active_merchant/billing/gateways/trust_commerce.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def authorize(money, creditcard_or_billing_id, options = {})
        parameters = {
          amount: amount(money)
        }
        Severity: Minor
        Found in lib/active_merchant/billing/gateways/trust_commerce.rb and 1 other location - About 25 mins to fix
        lib/active_merchant/billing/gateways/trust_commerce.rb on lines 169..181

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def purchase(money, creditcard_or_billing_id, options = {})
        parameters = {
          amount: amount(money)
        }
        Severity: Minor
        Found in lib/active_merchant/billing/gateways/trust_commerce.rb and 1 other location - About 25 mins to fix
        lib/active_merchant/billing/gateways/trust_commerce.rb on lines 152..164

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

              DECLINE_CODES = {
        'decline'       => 'The credit card was declined',
        'avs'           => 'AVS failed; the address entered does not match the billing address on file at the bank',
        'cvv'           => 'CVV failed; the number provided is not the correct verification number for the card',
        'call'          => 'The card must be authorized manually over the phone',
        Severity: Minor
        Found in lib/active_merchant/billing/gateways/trust_commerce.rb and 4 other locations - About 20 mins to fix
        lib/active_merchant/billing/gateways/authorize_net.rb on lines 22..35
        lib/active_merchant/billing/gateways/migs/migs_codes.rb on lines 56..69
        lib/active_merchant/billing/gateways/paypal_express.rb on lines 13..26
        lib/active_merchant/billing/gateways/plugnpay.rb on lines 21..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def capture(money, authorization, options = {})
        transaction_id, = split_authorization(authorization)
        parameters = {
          amount: amount(money),
          transid: transaction_id
        Severity: Minor
        Found in lib/active_merchant/billing/gateways/trust_commerce.rb and 1 other location - About 15 mins to fix
        lib/active_merchant/billing/gateways/trust_commerce.rb on lines 201..212

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def refund(money, identification, options = {})
        transaction_id, = split_authorization(identification)

        parameters = {
          amount: amount(money),
        Severity: Minor
        Found in lib/active_merchant/billing/gateways/trust_commerce.rb and 1 other location - About 15 mins to fix
        lib/active_merchant/billing/gateways/trust_commerce.rb on lines 187..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status