Shopify/verdict

View on GitHub

Showing 10 of 10 total issues

Class Experiment has 45 methods (exceeds 20 allowed). Consider refactoring.
Open

class Verdict::Experiment

  include Verdict::Metadata

  attr_reader :handle, :qualifiers, :event_logger
Severity: Minor
Found in lib/verdict/experiment.rb - About 6 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          def register_group(handle, size)
            percentage = size.kind_of?(Hash) && size[:percentage] ? size[:percentage] : size
            n = case percentage
              when :rest; 100 - @total_percentage_segmented
              when :half; 50
    Severity: Major
    Found in lib/verdict/segmenters/fixed_percentage_segmenter.rb and 1 other location - About 1 hr to fix
    lib/verdict/segmenters/rollout_segmenter.rb on lines 14..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          def register_group(handle, size)
            percentage = size.kind_of?(Hash) && size[:percentage] ? size[:percentage] : size
            n = case percentage
              when :rest; 100 - @total_percentage_segmented
              when :half; 50
    Severity: Major
    Found in lib/verdict/segmenters/rollout_segmenter.rb and 1 other location - About 1 hr to fix
    lib/verdict/segmenters/fixed_percentage_segmenter.rb on lines 14..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method assign has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def assign(subject, context = nil, dynamic_qualifiers: [])
        previous_assignment = lookup(subject)
    
        subject_identifier = retrieve_subject_identifier(subject)
        assignment = if previous_assignment
    Severity: Minor
    Found in lib/verdict/experiment.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          class Group < Verdict::Group
            attr_reader :percentile_range
    
            def initialize(experiment, handle, percentile_range)
              super(experiment, handle)
    Severity: Minor
    Found in lib/verdict/segmenters/rollout_segmenter.rb and 1 other location - About 40 mins to fix
    lib/verdict/segmenters/fixed_percentage_segmenter.rb on lines 33..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          class Group < Verdict::Group
    
            attr_reader :percentile_range
    
            def initialize(experiment, handle, percentile_range)
    Severity: Minor
    Found in lib/verdict/segmenters/fixed_percentage_segmenter.rb and 1 other location - About 40 mins to fix
    lib/verdict/segmenters/rollout_segmenter.rb on lines 33..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def initialize(experiment, subject, group, originally_created_at, temporary = false)
    Severity: Minor
    Found in lib/verdict/assignment.rb - About 35 mins to fix

      Method as_json has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def as_json(options = {})
          {
            handle: handle,
            has_qualifier: has_qualifier?,
            groups: segmenter.groups.values.map { |group| group.as_json(options) },
      Severity: Minor
      Found in lib/verdict/experiment.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def get(scope, key)
              redis.with do |conn|
                conn.hget(scope_key(scope), key)
              end
            rescue ::Redis::BaseError => e
      Severity: Minor
      Found in lib/verdict/storage/redis_storage.rb and 1 other location - About 15 mins to fix
      lib/verdict/storage/redis_storage.rb on lines 46..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def remove(scope, key)
              redis.with do |conn|
                conn.hdel(scope_key(scope), key)
              end
            rescue ::Redis::BaseError => e
      Severity: Minor
      Found in lib/verdict/storage/redis_storage.rb and 1 other location - About 15 mins to fix
      lib/verdict/storage/redis_storage.rb on lines 30..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language