Sign upLogin

Shopify/verdict

View on GitHub
Star

Showing 4 of 10 total issues

Class Experiment has 45 methods (exceeds 20 allowed). Consider refactoring.
Open

class Verdict::Experiment

  include Verdict::Metadata

  attr_reader :handle, :qualifiers, :event_logger
Severity: Minor
Found in lib/verdict/experiment.rb - About 6 hrs to fix

    Method assign has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def assign(subject, context = nil, dynamic_qualifiers: [])
    previous_assignment = lookup(subject)

    subject_identifier = retrieve_subject_identifier(subject)
    assignment = if previous_assignment
    Severity: Minor
    Found in lib/verdict/experiment.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def initialize(experiment, subject, group, originally_created_at, temporary = false)
    Severity: Minor
    Found in lib/verdict/assignment.rb - About 35 mins to fix

      Method as_json has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def as_json(options = {})
    {
      handle: handle,
      has_qualifier: has_qualifier?,
      groups: segmenter.groups.values.map { |group| group.as_json(options) },
      Severity: Minor
      Found in lib/verdict/experiment.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language