Sign upLogin

Shuttlerock/domain_validator

View on GitHub
Star

Showing 1 of 1 total issue

Method validate_each has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def validate_each(record, attribute, value)
        return if value.blank?

        # The shortest possible domain name something like Google's g.cn, which is four characters long
        # The longest possible domain name, as per RFC 1035, RFC 1123, and RFC 2181 is 253 characters
Severity: Minor
Found in lib/active_model/validations/domain_validator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language