Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLPortObject.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method loadFrom has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    void loadFrom(final InputStream is)
            throws IOException, XmlException {
        // use NonClosableInputStream to prevent multiple calling of close.
        // We do it in the next line.
        XmlObject xmlDoc = PCMLDocument.Factory.parse(
Severity: Minor
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLPortObject.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadFrom has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    void loadFrom(final InputStream is)
            throws IOException, XmlException {
        // use NonClosableInputStream to prevent multiple calling of close.
        // We do it in the next line.
        XmlObject xmlDoc = PCMLDocument.Factory.parse(
Severity: Major
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLPortObject.java - About 2 hrs to fix

Refactor this method to reduce its Cognitive Complexity from 43 to the 15 allowed.
Open

    void loadFrom(final InputStream is)
Severity: Critical
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLPortObject.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

There are no issues that match your filters.

Category
Status