Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLUtil.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method addOutport has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public static Outport addOutport(final ProcessNode processNode, 
            final PCMLPortObjectSpec spec) {
        Outport outport = processNode.addNewOutport();
        // add matrices
        MatrixRecipe matrixRecipe = outport.addNewMatrixRecipe();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLUtil.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addOutport has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static Outport addOutport(final ProcessNode processNode, 
            final PCMLPortObjectSpec spec) {
        Outport outport = processNode.addNewOutport();
        // add matrices
        MatrixRecipe matrixRecipe = outport.addNewMatrixRecipe();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLUtil.java - About 1 hr to fix

Method append has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static void append(final PCMLDocument doc, 
            final PCMLDocument toAppend) {
        Map<String, XmlObject> newNodes = PCMLUtil.append(doc, toAppend, 
                "ProcessNode");
        // TODO: this might be automated by getting the parent of ProcessNode.
Severity: Minor
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLUtil.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method append has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void append(final PCMLDocument doc, 
            final PCMLDocument toAppend) {
        Map<String, XmlObject> newNodes = PCMLUtil.append(doc, toAppend, 
                "ProcessNode");
        // TODO: this might be automated by getting the parent of ProcessNode.
Severity: Minor
Found in de.bund.bfr.knime.foodprocess.pcml/src/de/bund/bfr/knime/pcml/port/PCMLUtil.java - About 1 hr to fix

There are no issues that match your filters.

Category
Status