Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.foodprocess.util/src/de/bund/bfr/knime/util/FormulaEvaluator.java

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

        if (unit == null) return 1;
Severity: Major
Found in de.bund.bfr.knime.foodprocess.util/src/de/bund/bfr/knime/util/FormulaEvaluator.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return 1;
Severity: Major
Found in de.bund.bfr.knime.foodprocess.util/src/de/bund/bfr/knime/util/FormulaEvaluator.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

        if (unit.equalsIgnoreCase("m")) return 24*60*60*30;
Severity: Major
Found in de.bund.bfr.knime.foodprocess.util/src/de/bund/bfr/knime/util/FormulaEvaluator.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

        if (unit.equalsIgnoreCase("y")) return 24*60*60*365;
Severity: Major
Found in de.bund.bfr.knime.foodprocess.util/src/de/bund/bfr/knime/util/FormulaEvaluator.java - About 30 mins to fix

Method getSeconds has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public static double getSeconds(String unit) {
        if (unit == null) return 1;
        if (unit.equalsIgnoreCase("min")) return 60;
        if (unit.equalsIgnoreCase("h")) return 60*60;
        if (unit.equalsIgnoreCase("d")) return 24*60*60;
Severity: Minor
Found in de.bund.bfr.knime.foodprocess.util/src/de/bund/bfr/knime/util/FormulaEvaluator.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status