Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java

Summary

Maintainability
F
5 days
Test Coverage

File AddonC.java has 404 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 * Copyright (c) 2015 Federal Institute for Risk Assessment (BfR), Germany
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 5 hrs to fix

Method setSettings has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public void setSettings(Config c, double[] volumeDef, String[] volumeUnitDef) {
        panel1.removeAll();
        l1.clear();
        lmat.clear();
        lage.clear();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buttonActionPerformed has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private void buttonActionPerformed(ActionEvent e) {
        //System.err.println(e);
        int index = 0;
        JButton b = ((JButton) e.getSource());
        for (;index<l1.size();index++) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buttonPlusActionPerformed has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void buttonPlusActionPerformed(ActionEvent e) {
        removeAllFromPanel();
        
        JButton button = new JButton();
        button.setText("(select " + (forMatrices ? "Matrix" : "Agent") + ")");
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 2 hrs to fix

Method initComponents has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void initComponents() {
        // JFormDesigner - Component initialization - DO NOT MODIFY  //GEN-BEGIN:initComponents
        scrollPane2 = new JScrollPane();
        panel1 = new JPanel();
        button = new JButton();
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 2 hrs to fix

AddonC has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

public class AddonC extends JPanel {
    
    /**
     * 
     */
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 2 hrs to fix

Method setSettings has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void setSettings(Config c, double[] volumeDef, String[] volumeUnitDef) {
        panel1.removeAll();
        l1.clear();
        lmat.clear();
        lage.clear();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Method buttonPlusActionPerformed has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private void buttonPlusActionPerformed(ActionEvent e) {
        removeAllFromPanel();
        
        JButton button = new JButton();
        button.setText("(select " + (forMatrices ? "Matrix" : "Agent") + ")");
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buttonActionPerformed has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void buttonActionPerformed(ActionEvent e) {
        //System.err.println(e);
        int index = 0;
        JButton b = ((JButton) e.getSource());
        for (;index<l1.size();index++) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Method saveSettings has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public void saveSettings(Config cM) {
        int[] iarr;
        String[] narr;
        if (forMatrices) {
            iarr = new int[lmat.size()];
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getNArr has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public String[] getNArr() {
        String[] narr;
        if (forMatrices) {
            narr = new String[lmat.size()];
            for (int i=0;i<lmat.size();i++) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getIArr has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public int[] getIArr() {
        int[] iarr;
        if (forMatrices) {
            iarr = new int[lmat.size()];
            for (int i=0;i<lmat.size();i++) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buttonMinusActionPerformed has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private void buttonMinusActionPerformed(ActionEvent e) {
        if (l5.size() > 1) {
            removeAllFromPanel();
            
            JButton b = (JButton) e.getSource();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this method to reduce its Cognitive Complexity from 28 to the 15 allowed.
Open

    private void buttonActionPerformed(ActionEvent e) {
Severity: Critical
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.
Open

    private void buttonPlusActionPerformed(ActionEvent e) {
Severity: Critical
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Refactor this method to reduce its Cognitive Complexity from 29 to the 15 allowed.
Open

    public void setSettings(Config c, double[] volumeDef, String[] volumeUnitDef) {
Severity: Critical
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Define a constant instead of duplicating this literal "Matrix" 3 times.
Open

        button.setText("(select " + (forMatrices ? "Matrix" : "Agent") + ")");
Severity: Critical
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "Agent" 3 times.
Open

        button.setText("(select " + (forMatrices ? "Matrix" : "Agent") + ")");
Severity: Critical
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public String[] getNArr() {
        String[] narr;
        if (forMatrices) {
            narr = new String[lmat.size()];
            for (int i=0;i<lmat.size();i++) {
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 2 hrs to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 138..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public int[] getIArr() {
        int[] iarr;
        if (forMatrices) {
            iarr = new int[lmat.size()];
            for (int i=0;i<lmat.size();i++) {
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 2 hrs to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 158..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        else {
            iarr = new int[lage.size()];
            narr = new String[lage.size()];
            for (int i=0;i<lage.size();i++) {
                if (lage.get(i) != null) {
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 181..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (forMatrices) {
            iarr = new int[lmat.size()];
            narr = new String[lmat.size()];
            for (int i=0;i<lmat.size();i++) {
                if (lmat.get(i) != null) {
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 191..200

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (volumeDef == null || volumeDef.length < 1) {
            l1.add(button);
            if (forMatrices) lmat.add(null); else lage.add(null);
            l2.add(formattedTextField1);
            l3.add(comboBox2);
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 50 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 297..304

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        else {
            l1.add(button);
            if (forMatrices) lmat.add(null); else lage.add(null);
            l2.add(formattedTextField);
            l3.add(comboBoxEinheit);
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 50 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 81..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        if (forMatrices) {
                            Matrix m = new Matrix(narr[i], iarr[i]);
                            l1.get(i).setText(m.getName());
                            lmat.set(i, m);                        
                        }
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 35 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 103..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        else {
                            Agent a = new Agent(narr[i], iarr[i]);
                            l1.get(i).setText(a.getName());
                            lage.set(i, a);
                        }
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 35 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 98..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        else id = (index >= lage.size() || lage.get(index) == null) ? null : lage.get(index).getId();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 30 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 354..354

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            else {
                if (index < lage.size()) {
                    lage.set(index, new Agent(mname, (Integer) newVal));
                    l1.set(index, b);
                }
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 30 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 369..374

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (forMatrices) id = (index >= lmat.size() || lmat.get(index) == null) ? null : lmat.get(index).getId();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 30 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 355..355

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (forMatrices) {
                if (index < lmat.size()) {
                    lmat.set(index, new Matrix(mname, (Integer) newVal));
                    l1.set(index, b);
                }
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java and 1 other location - About 30 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/addons/AddonC.java on lines 375..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status