Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java

Summary

Maintainability
C
1 day
Test Coverage

Method setModel4AgentsDef has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private void setModel4AgentsDef(final String[] agentsDefStr, final double[][] agentsDefDbl) {
        Object[][] tableContent = null;
        if (agentsDefStr != null) {
            tableContent = new Object[agentsDefStr.length][5];
            for (int i=0;i<agentsDefStr.length;i++) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setModel4AgentsDef has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void setModel4AgentsDef(final String[] agentsDefStr, final double[][] agentsDefDbl) {
        Object[][] tableContent = null;
        if (agentsDefStr != null) {
            tableContent = new Object[agentsDefStr.length][5];
            for (int i=0;i<agentsDefStr.length;i++) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java - About 1 hr to fix

Method getSetting has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public AgentsSetting getSetting() throws InvalidSettingsException {        
        AgentsSetting as;

        as = new AgentsSetting();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getSetting has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public AgentsSetting getSetting() throws InvalidSettingsException {        
        AgentsSetting as;

        as = new AgentsSetting();
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java - About 1 hr to fix

Method getTableCellRendererComponent has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

            public Component getTableCellRendererComponent(JTable arg0,
                    Object arg1, boolean arg2, boolean arg3, int arg4, int arg5) {
Severity: Minor
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java - About 45 mins to fix

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
Open

    private void setModel4AgentsDef(final String[] agentsDefStr, final double[][] agentsDefDbl) {
Severity: Critical
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                tableContent[i][1] = agentsDefDbl[0][i] == -1 ? null : agentsDefDbl[0][i];;
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 148..148
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 149..149
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 150..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                tableContent[i][4] = agentsDefDbl[3][i] == -1 ? null : agentsDefDbl[3][i];
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 147..147
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 148..148
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 149..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                tableContent[i][2] = agentsDefDbl[1][i] == -1 ? null : agentsDefDbl[1][i];
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 147..147
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 149..149
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 150..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                tableContent[i][3] = agentsDefDbl[2][i] == -1 ? null : agentsDefDbl[2][i];
Severity: Major
Found in de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 147..147
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 148..148
de.bund.bfr.knime.foodprocess/src/de/bund/bfr/knime/foodprocess/lib/AgentsDef.java on lines 150..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status