Method eIsSet has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
@Override
public boolean eIsSet(int featureID) {
switch (featureID) {
case MetadataPackage.STUDY_SAMPLE__SAMPLE_NAME:
return SAMPLE_NAME_EDEFAULT == null ? sampleName != null : !SAMPLE_NAME_EDEFAULT.equals(sampleName);- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
StudySampleImpl has 26 methods (exceeds 20 allowed). Consider refactoring. Open
public class StudySampleImpl extends MinimalEObjectImpl.Container implements StudySample {
/**
* The default value of the '{@link #getSampleName() <em>Sample Name</em>}' attribute.
* <!-- begin-user-doc -->
* <!-- end-user-doc -->- Create a ticketCreate a ticket
File StudySampleImpl.java has 277 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
*/
package metadata.impl;
import metadata.MetadataPackage;- Create a ticketCreate a ticket
Method eUnset has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public void eUnset(int featureID) {
switch (featureID) {
case MetadataPackage.STUDY_SAMPLE__SAMPLE_NAME:
setSampleName(SAMPLE_NAME_EDEFAULT);- Create a ticketCreate a ticket
Method eSet has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public void eSet(int featureID, Object newValue) {
switch (featureID) {
case MetadataPackage.STUDY_SAMPLE__SAMPLE_NAME:
setSampleName((String)newValue);- Create a ticketCreate a ticket
Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. Open
public boolean eIsSet(int featureID) {- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.
See
Add a default case to this switch. Open
switch (featureID) {- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
The requirement for a final default clause is defensive programming. The clause should either take appropriate action, or contain a
suitable comment as to why no action is taken.
Noncompliant Code Example
switch (param) { //missing default clause
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
switch (param) {
default: // default clause should be the last one
error();
break;
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
Compliant Solution
switch (param) {
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
default:
error();
break;
}
Exceptions
If the switch parameter is an Enum and if all the constants of this enum are used in the case statements,
then no default clause is expected.
Example:
public enum Day {
SUNDAY, MONDAY
}
...
switch(day) {
case SUNDAY:
doSomething();
break;
case MONDAY:
doSomethingElse();
break;
}
See
- MITRE, CWE-478 - Missing Default Case in Switch Statement
- CERT, MSC01-C. - Strive for logical completeness
Add a default case to this switch. Open
switch (featureID) {- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
The requirement for a final default clause is defensive programming. The clause should either take appropriate action, or contain a
suitable comment as to why no action is taken.
Noncompliant Code Example
switch (param) { //missing default clause
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
switch (param) {
default: // default clause should be the last one
error();
break;
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
Compliant Solution
switch (param) {
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
default:
error();
break;
}
Exceptions
If the switch parameter is an Enum and if all the constants of this enum are used in the case statements,
then no default clause is expected.
Example:
public enum Day {
SUNDAY, MONDAY
}
...
switch(day) {
case SUNDAY:
doSomething();
break;
case MONDAY:
doSomethingElse();
break;
}
See
- MITRE, CWE-478 - Missing Default Case in Switch Statement
- CERT, MSC01-C. - Strive for logical completeness
Add a default case to this switch. Open
switch (featureID) {- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
The requirement for a final default clause is defensive programming. The clause should either take appropriate action, or contain a
suitable comment as to why no action is taken.
Noncompliant Code Example
switch (param) { //missing default clause
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
switch (param) {
default: // default clause should be the last one
error();
break;
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
Compliant Solution
switch (param) {
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
default:
error();
break;
}
Exceptions
If the switch parameter is an Enum and if all the constants of this enum are used in the case statements,
then no default clause is expected.
Example:
public enum Day {
SUNDAY, MONDAY
}
...
switch(day) {
case SUNDAY:
doSomething();
break;
case MONDAY:
doSomethingElse();
break;
}
See
- MITRE, CWE-478 - Missing Default Case in Switch Statement
- CERT, MSC01-C. - Strive for logical completeness
Add a default case to this switch. Open
switch (featureID) {- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
The requirement for a final default clause is defensive programming. The clause should either take appropriate action, or contain a
suitable comment as to why no action is taken.
Noncompliant Code Example
switch (param) { //missing default clause
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
switch (param) {
default: // default clause should be the last one
error();
break;
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
}
Compliant Solution
switch (param) {
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
default:
error();
break;
}
Exceptions
If the switch parameter is an Enum and if all the constants of this enum are used in the case statements,
then no default clause is expected.
Example:
public enum Day {
SUNDAY, MONDAY
}
...
switch(day) {
case SUNDAY:
doSomething();
break;
case MONDAY:
doSomethingElse();
break;
}
See
- MITRE, CWE-478 - Missing Default Case in Switch Statement
- CERT, MSC01-C. - Strive for logical completeness