Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.fsklab.metadata.model/src/de/bund/bfr/knime/fsklab/rakip/RakipUtil.java

Summary

Maintainability
D
2 days
Test Coverage

File RakipUtil.java has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package de.bund.bfr.knime.fsklab.rakip;

import java.math.BigDecimal;
import java.util.Date;
import java.util.HashMap;
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/de/bund/bfr/knime/fsklab/rakip/RakipUtil.java - About 5 hrs to fix

Method convert has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static de.bund.bfr.metadata.swagger.GenericModelGeneralInformation convert(
            GeneralInformation deprecatedGI) {

        de.bund.bfr.metadata.swagger.GenericModelGeneralInformation generalInformation = new de.bund.bfr.metadata.swagger.GenericModelGeneralInformation();
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/de/bund/bfr/knime/fsklab/rakip/RakipUtil.java - About 1 hr to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    static {
        PUBLICATION_TYPE = new HashMap<>();

        PUBLICATION_TYPE.put(Type.ABST, PublicationTypeEnum.ABST);
        PUBLICATION_TYPE.put(Type.ADVS, PublicationTypeEnum.ADVS);
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/de/bund/bfr/knime/fsklab/rakip/RakipUtil.java and 1 other location - About 1 day to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerUtil.java on lines 457..516

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 782.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    static {
        CLASSIF = new HashMap<>();

        CLASSIF.put(Parameter.Classification.input, de.bund.bfr.metadata.swagger.Parameter.ClassificationEnum.INPUT);
        CLASSIF.put(Parameter.Classification.output, de.bund.bfr.metadata.swagger.Parameter.ClassificationEnum.OUTPUT);
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/de/bund/bfr/knime/fsklab/rakip/RakipUtil.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerUtil.java on lines 520..529

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status