Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java

Summary

Maintainability
F
5 days
Test Coverage

Method join has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

    private JsonNode join(JsonNode metadataA, Map<String, Object> originalClassA, JsonNode metadataB,
            Map<String, Object> originalClassB, Map<String, Object> targetClass) {

        Map<String, Object> classAProperties = getProperties(originalClassA);
        Map<String, Object> classBProperties = getProperties(originalClassB);
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convert has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    private JsonNode convert(JsonNode originalMetadata, Map<String, Object> originalClass,
            Map<String, Object> targetClass) {
          if(originalMetadata == null) {
          return null;
        }
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ConversionUtils.java has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package metadata;

import java.io.IOException;
import java.io.InputStream;
import java.util.Collections;
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 3 hrs to fix

Method join has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private JsonNode join(JsonNode metadataA, Map<String, Object> originalClassA, JsonNode metadataB,
            Map<String, Object> originalClassB, Map<String, Object> targetClass) {

        Map<String, Object> classAProperties = getProperties(originalClassA);
        Map<String, Object> classBProperties = getProperties(originalClassB);
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 2 hrs to fix

Method convert has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private JsonNode convert(JsonNode originalMetadata, Map<String, Object> originalClass,
            Map<String, Object> targetClass) {
          if(originalMetadata == null) {
          return null;
        }
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 2 hrs to fix

Method joinModels has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Model joinModels(JsonNode modelA, JsonNode modelB, ModelClass targetModelType) throws JsonProcessingException {

        String modelAType = modelA.get("modelType").textValue();
        Map<String, Object> modelAClass = ModelClass.valueOf(modelAType).swaggerDefinition;
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 1 hr to fix

Method convertModel has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Model convertModel(JsonNode originalMetadata, ModelClass targetClass) throws JsonProcessingException {

        String originalClass = originalMetadata.get("modelType").textValue();
        Map<String, Object> originalModelClass = ModelClass.valueOf(originalClass).swaggerDefinition;
        Map<String, Object> targetModelClass = targetClass.swaggerDefinition;
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 1 hr to fix

Method getProperties has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private Map<String, Object> getProperties(Map<String, Object> property) {

        if (property.containsKey(TYPE)) {
            if (property.get(TYPE).equals("object")) {
                return (Map<String, Object>) property.get(PROPERTIES);
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if (newValue != null) {
                            node.set(key, newValue);
                        }
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        if(!field.getValue().toString().equals("\"\"") && !field.getValue().toString().equals("\"-\""))
                            node.set(key, field.getValue());
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 45 mins to fix

Method join has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private JsonNode join(JsonNode metadataA, Map<String, Object> originalClassA, JsonNode metadataB,
            Map<String, Object> originalClassB, Map<String, Object> targetClass) {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 35 mins to fix

Method combineDateProperties has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private static JsonNode combineDateProperties(String key, Map<String, Object> propA, JsonNode metadataA,
            Map<String, Object> propB, JsonNode metadataB) {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 35 mins to fix

Method combineStringProperties has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private static String combineStringProperties(String key, Map<String, Object> propA, JsonNode metadataA,
            Map<String, Object> propB, JsonNode metadataB) {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 35 mins to fix

Method combineStringProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private static String combineStringProperties(String key, Map<String, Object> propA, JsonNode metadataA,
            Map<String, Object> propB, JsonNode metadataB) {
        String modelAValue = "";
        if (!propA.isEmpty() && ((String) propA.get(TYPE)).equals("string") && metadataA.has(key)
                && !metadataA.get(key).isNull()) {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this method to reduce its Cognitive Complexity from 47 to the 15 allowed.
Open

    private JsonNode convert(JsonNode originalMetadata, Map<String, Object> originalClass,
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Refactor this method to reduce its Cognitive Complexity from 62 to the 15 allowed.
Open

    private JsonNode join(JsonNode metadataA, Map<String, Object> originalClassA, JsonNode metadataB,
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Define a constant instead of duplicating this literal "allOf" 5 times.
Open

        List<Object> allOf = (List<Object>) originalModelClass.get("allOf");
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "array" 3 times.
Open

                    }else if (originalPropType.equals("array")) {
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "modelType" 5 times.
Open

        String originalClass = originalMetadata.get("modelType").textValue();
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "string" 6 times.
Open

                    if (originalPropType.equals("string") || originalPropType.equals("number")) {
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "format" 4 times.
Open

                    if (targetProp.containsKey("format") && targetProp.get("format").equals("date")) {
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    if (metadataA.has(key)) {
                        for (JsonNode child : metadataA.get(key)) {
                          if (child.isTextual()) {
                            joinedArray.add(child.asText());
                          } else if (child.isObject()) {
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 295..304

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    if (metadataB.has(key)) {
                        for (JsonNode child : metadataB.get(key)) {
                            if (child.isTextual()) {
                              joinedArray.add(child.asText());
                            } else if (child.isObject()) {
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 284..293

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!propB.isEmpty() && ((String) propB.get(TYPE)).equals("string") && ((String) propB.get("format")).equals("date")
                && metadataB.has(key) && !metadataB.get(key).isNull()) {
            return metadataA.get(key);
        }
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 350..353

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!propA.isEmpty() && ((String) propA.get(TYPE)).equals("string") && ((String) propA.get("format")).equals("date")
                && metadataA.has(key) && !metadataA.get(key).isNull()) {
            return metadataA.get(key);
        }
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 355..358

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!propB.isEmpty() && ((String) propB.get(TYPE)).equals("string") && metadataB.has(key)
                && !metadataB.get(key).isNull()) {
            modelBValue = metadataB.get(key).asText();
        }
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 1 other location - About 50 mins to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 329..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!propA.isEmpty() && ((String) propA.get(TYPE)).equals("string") && metadataA.has(key)
                && !metadataA.get(key).isNull()) {
            modelAValue = metadataA.get(key).asText();
        }
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 1 other location - About 50 mins to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 335..338

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        JsonNode generalInformationNode = join(modelA.get(GENERAL_INFORMATION),
                (Map<String, Object>) modelATopComponents.get(GENERAL_INFORMATION), modelB.get(GENERAL_INFORMATION),
                (Map<String, Object>) modelBTopComponents.get(GENERAL_INFORMATION),
                (Map<String, Object>) targetTopComponents.get(GENERAL_INFORMATION));
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 163..165
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 166..169
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 170..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        JsonNode scopeNode = join(modelA.get(SCOPE), (Map<String, Object>) modelATopComponents.get(SCOPE),
                modelB.get(SCOPE), (Map<String, Object>) modelBTopComponents.get(SCOPE),
                (Map<String, Object>) targetTopComponents.get(SCOPE));
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 159..162
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 166..169
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 170..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        JsonNode mathNode = join(modelA.get(MODEL_MATH), (Map<String, Object>) modelATopComponents.get(MODEL_MATH),
                modelB.get(MODEL_MATH), (Map<String, Object>) modelBTopComponents.get(MODEL_MATH),
                (Map<String, Object>) targetTopComponents.get(MODEL_MATH));
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 159..162
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 163..165
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 166..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        JsonNode backgroundNode = join(modelA.get(DATA_BACKGROUND),
                (Map<String, Object>) modelATopComponents.get(DATA_BACKGROUND), modelB.get(DATA_BACKGROUND),
                (Map<String, Object>) modelBTopComponents.get(DATA_BACKGROUND),
                (Map<String, Object>) targetTopComponents.get(DATA_BACKGROUND));
Severity: Major
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java and 3 other locations - About 35 mins to fix
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 159..162
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 163..165
de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java on lines 170..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      exposureModel(ExposureModel.class, definitions.get("ExposureModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      doseResponseModel(DoseResponseModel.class, definitions.get("DoseResponseModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      predictiveModel(PredictiveModel.class, definitions.get("PredictiveModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      healthModel(HealthModel.class, definitions.get("HealthModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      qraModel(QraModel.class, definitions.get("QraModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      dataModel(DataModel.class, definitions.get("DataModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      toxicologicalModel(ToxicologicalModel.class, definitions.get("ToxicologicalModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      processModel(ProcessModel.class, definitions.get("ProcessModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      consumptionModel(ConsumptionModel.class, definitions.get("ConsumptionModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      GenericModel(GenericModel.class, definitions.get("GenericModel"));
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      otherModel(OtherModel.class, definitions.get("OtherModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      riskModel(RiskModel.class, definitions.get("RiskModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
Open

      genericModel(GenericModel.class, definitions.get("GenericModel")),
Severity: Critical
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java by sonar-java

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all constant names match a provided regular expression.

Noncompliant Code Example

With the default regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$:

public class MyClass {
  public static final int first = 1;
}

public enum MyEnum {
  first;
}

Compliant Solution

public class MyClass {
  public static final int FIRST = 1;
}

public enum MyEnum {
  FIRST;
}

There are no issues that match your filters.

Category
Status