Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/JsonHandler.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method applyJoinRelation has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  public void applyJoinRelation(FskPortObject fskObj, List<JoinRelationAdvanced> joinRelationList,
      String suffix) throws Exception {

    // figure out which parameters from JoinRelations belong to which model to avoid loading
    // a json file twice
Severity: Minor
Found in de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/JsonHandler.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

            if (joinRelation.getTargetParam().equals(param.getId() + suffix)) {
              addEntryToRelationMap(sourceTargetPathMap,joinRelation, param );
    
            }
Severity: Major
Found in de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/JsonHandler.java - About 45 mins to fix

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed.
Open

  public void applyJoinRelation(FskPortObject fskObj, List<JoinRelationAdvanced> joinRelationList,
Severity: Critical
Found in de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/JsonHandler.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

There are no issues that match your filters.

Category
Status