Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java

Summary

Maintainability
F
3 days
Test Coverage

Method createBufferedDataTable has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    public BufferedDataTable createBufferedDataTable(final ExecutionContext exec) {
        DataTableSpec spec = m_spec.createDataTableSpec();
        BufferedDataContainer container = exec.createDataContainer(spec);
        for (JSONDataTableRow row : m_rows) {
            DataCell[] dataCells = new DataCell[row.getData().length];
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File JSONDataTable.java has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package de.bund.bfr.knime.node.editableTable;

/*
 * ------------------------------------------------------------------------
 *  Copyright by KNIME GmbH, Konstanz, Germany
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 5 hrs to fix

Method createBufferedDataTable has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public BufferedDataTable createBufferedDataTable(final ExecutionContext exec) {
        DataTableSpec spec = m_spec.createDataTableSpec();
        BufferedDataContainer container = exec.createDataContainer(spec);
        for (JSONDataTableRow row : m_rows) {
            DataCell[] dataCells = new DataCell[row.getData().length];
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 2 hrs to fix

Method equals has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(final Object obj) {
        if (this == obj) {
            return true;
        }
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method equals has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        @Override
        public boolean equals(final Object obj) {
            if (this == obj) {
                return true;
            }
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                    return false;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return true;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java - About 30 mins to fix

Refactor this method to reduce its Cognitive Complexity from 44 to the 15 allowed.
Open

    public JSONDataTable(final DataTable dTable, final int firstRow,
Severity: Critical
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Refactor this method to reduce its Cognitive Complexity from 46 to the 15 allowed.
Open

    public BufferedDataTable createBufferedDataTable(final ExecutionContext exec) {
Severity: Critical
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Define a constant instead of duplicating this literal "Value " 3 times.
Open

                        dataCells[colId] = new MissingCell("Value " + value + "could not be parsed as boolean.");
Severity: Critical
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (maxValues[c] == null) {
                    maxValues[c] = cell;
                    maxJSONValues[c] = getJSONCellValue(cell);
                } else {
                    if (comp.compare(maxValues[c], cell) < 0) {
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 242..250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (minValues[c] == null) {
                    minValues[c] = cell;
                    minJSONValues[c] = getJSONCellValue(cell);
                } else {
                    if (comp.compare(minValues[c], cell) > 0) {
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 252..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

            if (m_rowKey == null) {
                if (other.m_rowKey != null) {
                    return false;
                }
            } else if (!m_rowKey.equals(other.m_rowKey)) {
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 6 other locations - About 35 mins to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 589..595
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 467..473
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 474..480
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 481..487
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 488..494
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 510..516

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

        if (m_spec == null) {
            if (other.m_spec != null) {
                return false;
            }
        } else if (!m_spec.equals(other.m_spec)) {
Severity: Major
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 6 other locations - About 35 mins to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 501..507
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 467..473
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 474..480
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 481..487
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 488..494
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTableSpec.java on lines 510..516

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                    if (value instanceof Number) {
                        nVal = (Number)value;
                    } else  if (value instanceof String) {
                        nVal = Double.parseDouble((String)value);
                    }
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 2 other locations - About 30 mins to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 324..328
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 312..316

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                    if (value instanceof Boolean) {
                        bVal = (Boolean)value;
                    } else if (value instanceof String) {
                        bVal = Boolean.parseBoolean((String)value);
                    }
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 2 other locations - About 30 mins to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 336..340
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 324..328

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                    if (value instanceof Long) {
                        lVal = (Long)value;
                    } else if (value instanceof String) {
                        lVal = Long.parseLong((String)value);
                    }
Severity: Minor
Found in de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java and 2 other locations - About 30 mins to fix
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 336..340
de.bund.bfr.knime.internal.nodes/src/de/bund/bfr/knime/node/editableTable/JSONDataTable.java on lines 312..316

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status