Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java

Summary

Maintainability
D
2 days
Test Coverage

File ParametricModelTest.java has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 * Copyright (c) 2015 Federal Institute for Risk Assessment (BfR), Germany
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Minor
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java - About 4 hrs to fix

ParametricModelTest has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings("static-method")
public class ParametricModelTest {

    @Test
    public void testEmptyConstructor() {
Severity: Minor
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java - About 2 hrs to fix

Method testToXmlElement has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Test
    public void testToXmlElement() throws DataConversionException {

        Element element = new ParametricModel().toXmlElement();
        assertEquals("ParametricModel", element.getName());
Severity: Minor
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java - About 1 hr to fix

Method testParameterSetters has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Test
    public void testParameterSetters() {
        final ParametricModel model = new ParametricModel();
        model.addParam("param", false);
Severity: Minor
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java - About 1 hr to fix

Method testIndependentSetters has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Test
    public void testIndependentSetters() {
        final ParametricModel model = new ParametricModel();
        model.addIndepVar("indep");
Severity: Minor
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java - About 1 hr to fix

Method testConstructor2 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Test
    public void testConstructor2() {

        final DepXml dep = new DepXml("dep");
Severity: Minor
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java - About 1 hr to fix

Define a constant instead of duplicating this literal "description" 6 times.
Open

        model.setIndepDescription("aloha", "description");
Severity: Critical
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "Baldur" 20 times.
Open

        model.addParam("Baldur", true);
Severity: Critical
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "category" 6 times.
Open

        model.setIndepCategory("aloha", "category");
Severity: Critical
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "aloha" 27 times.
Open

        model.setIndepDescription("aloha", "description");
Severity: Critical
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java by sonar-java

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

Compliant Solution

private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testModelLiterature() {

        final ParametricModel model = new ParametricModel();
        assertEquals(0, model.getModelLit().size());
Severity: Major
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 406..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testEstimatedModelLiterature() {

        final ParametricModel model = new ParametricModel();
        assertEquals(0, model.getEstModelLit().size());
Severity: Major
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 388..404

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    public void testRMS() {
        final ParametricModel model = new ParametricModel();

        // Empty constructor assigns Double#NAN to aic
Severity: Major
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java and 2 other locations - About 1 hr to fix
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 95..112
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 114..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    public void testBic() {
        final ParametricModel model = new ParametricModel();

        // Empty constructor assigns Double#NAN to aic
Severity: Major
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java and 2 other locations - About 1 hr to fix
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 95..112
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 133..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    public void testAic() {
        final ParametricModel model = new ParametricModel();

        // Empty constructor assigns Double#NAN to aic
Severity: Major
Found in de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java and 2 other locations - About 1 hr to fix
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 114..131
de.bund.bfr.knime.pmm.common.tests/src/de/bund/bfr/knime/pmm/common/ParametricModelTest.java on lines 133..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status