de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/DBUtilities.java
Method getLiteratureItem
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static LiteratureItem getLiteratureItem(Connection conn, Integer id, String dbuuid) {
String author = (String) DBKernel.getValue(conn, "Literatur", "ID", id
+ "", "Erstautor");
String title = (String) DBKernel.getValue(conn, "Literatur", "ID", id
+ "", "Titel");
- Create a ticketCreate a ticket
Define a constant instead of duplicating this literal "Literatur" 12 times. Open
Open
String author = (String) DBKernel.getValue(conn, "Literatur", "ID", id
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
public void run() { prepare("action1"); // Noncompliant - "action1" is duplicated 3 times execute("action1"); release("action1"); } @SuppressWarning("all") // Compliant - annotations are excluded private void method1() { /* ... */ } @SuppressWarning("all") private void method2() { /* ... */ } public String method3(String a) { System.out.println("'" + a + "'"); // Compliant - literal "'" has less than 5 characters and is excluded return ""; // Compliant - literal "" has less than 5 characters and is excluded }
Compliant Solution
private static final String ACTION_1 = "action1"; // Compliant public void run() { prepare(ACTION_1); // Compliant execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.