Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method getMiscUnits has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static Map<String, String> getMiscUnits(List<KnimeTuple> tuples) {
        Map<String, Map<String, Integer>> occurences = new LinkedHashMap<>();
        Map<String, String> map = new LinkedHashMap<>();

        for (KnimeTuple tuple : tuples) {
Severity: Minor
Found in de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMiscUnits has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static Map<String, String> getMiscUnits(List<KnimeTuple> tuples) {
        Map<String, Map<String, Integer>> occurences = new LinkedHashMap<>();
        Map<String, String> map = new LinkedHashMap<>();

        for (KnimeTuple tuple : tuples) {
Severity: Minor
Found in de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java - About 1 hr to fix

Method isOutOfRange has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static boolean isOutOfRange(PmmXmlDoc paramXml) {
        for (PmmXmlElementConvertable el : paramXml.getElementSet()) {
            ParamXml element = (ParamXml) el;

            if (element.value != null) {
Severity: Minor
Found in de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
Open

    public static Map<String, String> getMiscUnits(List<KnimeTuple> tuples) {
Severity: Critical
Found in de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static List<String> getIndeps(List<KnimeTuple> tuples) {
        Set<String> indepSet = new LinkedHashSet<>();

        for (KnimeTuple tuple : tuples) {
            PmmXmlDoc indep = tuple.getPmmXml(Model1Schema.ATT_INDEPENDENT);
Severity: Major
Found in de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java on lines 64..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static List<String> getMiscParams(List<KnimeTuple> tuples) {
        Set<String> paramSet = new LinkedHashSet<>();

        for (KnimeTuple tuple : tuples) {
            PmmXmlDoc misc = tuple.getPmmXml(TimeSeriesSchema.ATT_MISC);
Severity: Major
Found in de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.pmm.common/src/de/bund/bfr/knime/pmm/common/pmmtablemodel/PmmUtilities.java on lines 53..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status