de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/nodes/Plugin.java
Rename this class. Open
Open
public class Plugin extends org.eclipse.core.runtime.Plugin {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
While it's perfectly legal to give a class the same simple name as a class in another package that it extends or interface it implements, it's confusing and could cause problems in the future.
Noncompliant Code Example
package my.mypackage; public class Foo implements a.b.Foo { // Noncompliant
Compliant Solution
package my.mypackage; public class FooJr implements a.b.Foo {
Make the enclosing method "static" or remove this set. Open
Open
plugin = null;
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Correctly updating a static
field from a non-static method is tricky to get right and could easily lead to bugs if there are multiple
class instances and/or multiple threads in play. Ideally, static
fields are only updated from synchronized static
methods.
This rule raises an issue each time a static
field is updated from a non-static method.
Noncompliant Code Example
public class MyClass { private static int count = 0; public void doSomething() { //... count++; // Noncompliant } }