de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/predictorview/SettingsHelper.java
SettingsHelper
has 64 methods (exceeds 20 allowed). Consider refactoring. Open
Open
public class SettingsHelper {
private static final String CFG_SELECTEDIDS = "SelectedIDs";
private static final String CFG_PARAMXVALUES = "ParamXValues";
private static final String CFG_TIMEVALUES = "TimeValues";
- Create a ticketCreate a ticket
File SettingsHelper.java
has 495 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
/*******************************************************************************
* Copyright (c) 2015 Federal Institute for Risk Assessment (BfR), Germany
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
- Create a ticketCreate a ticket
Method loadSettings
has 141 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public void loadSettings(NodeSettingsRO settings) {
try {
selectedIDs = XmlConverter.xmlToObject(
settings.getString(CFG_SELECTEDIDS),
new ArrayList<String>());
- Create a ticketCreate a ticket
Method loadSettings
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
Open
public void loadSettings(NodeSettingsRO settings) {
try {
selectedIDs = XmlConverter.xmlToObject(
settings.getString(CFG_SELECTEDIDS),
new ArrayList<String>());
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method saveSettings
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public void saveSettings(NodeSettingsWO settings) {
settings.addString(CFG_SELECTEDIDS,
XmlConverter.objectToXml(selectedIDs));
settings.addString(CFG_PARAMXVALUES,
XmlConverter.objectToXml(paramXValues));
- Create a ticketCreate a ticket
Refactor this method to reduce its Cognitive Complexity from 30 to the 15 allowed. Open
Open
public void loadSettings(NodeSettingsRO settings) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.