Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java

Summary

Maintainability
F
4 days
Test Coverage

SettingsHelper has 78 methods (exceeds 20 allowed). Consider refactoring.
Open

public class SettingsHelper {

    public static final String DO_NOT_USE = "Do Not Use";
    public static final String OTHER_PARAMETER = "Select Other";
    public static final String SELECT = "Select";
Severity: Major
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java - About 1 day to fix

File SettingsHelper.java has 574 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 * Copyright (c) 2015 Federal Institute for Risk Assessment (BfR), Germany
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Major
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java - About 1 day to fix

Method loadSettings has 168 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void loadSettings(NodeSettingsRO settings) {
        try {
            fileName = settings.getString(CFG_FILE_NAME);
        } catch (InvalidSettingsException e) {
        }
Severity: Major
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java - About 6 hrs to fix

Method loadSettings has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    public void loadSettings(NodeSettingsRO settings) {
        try {
            fileName = settings.getString(CFG_FILE_NAME);
        } catch (InvalidSettingsException e) {
        }
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method saveSettings has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void saveSettings(NodeSettingsWO settings) {
        settings.addString(CFG_FILE_NAME, fileName);
        settings.addString(CFG_SHEET_NAME, sheetName);
        settings.addBoolean(CFG_PRESERVE_IDS, preserveIds);
        settings.addString(CFG_USED_IDS, XmlConverter.objectToXml(usedIds));
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java - About 1 hr to fix

Refactor this method to reduce its Cognitive Complexity from 38 to the 15 allowed.
Open

    public void loadSettings(NodeSettingsRO settings) {
Severity: Critical
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/xlsmodelreader/SettingsHelper.java by sonar-java

Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

See

There are no issues that match your filters.

Category
Status