Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star

Showing 14,752 of 14,752 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

package de.bund.bfr.knime.fsklab.nodes.environment;

import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Optional;
Severity: Major
Found in de.bund.bfr.knime.fsklab.nodes/src/de/bund/bfr/knime/fsklab/nodes/environment/DefaultEnvironmentManager.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.deprecatednodes/src-1_9_0/de/bund/bfr/knime/fsklab/nodes/environment/DefaultEnvironmentManager.java on lines 1..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  public static ScriptHandler createHandler(String script_type, List<String> packages) throws Exception {
    
    final ScriptHandler handler;
    
    if (script_type == null) {
Severity: Major
Found in de.bund.bfr.knime.fsklab.deprecatednodes/src-1_7_2/de/bund/bfr/knime/fsklab/nodes/ScriptHandler.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.fsklab.deprecatednodes/src-1_9_0/de/bund/bfr/knime/fsklab/nodes/v1_9/ScriptHandler.java on lines 158..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testConstructors() {
        final Indep indep = new Indep();
        assertThat(indep.name, is(nullValue()));
        assertThat(indep.origname, is(nullValue()));
Severity: Major
Found in de.bund.bfr.knime.pmm.nodes.tests/src/de/bund/bfr/knime/pmm/js/common/IndepTest.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.pmm.nodes.tests/src/de/bund/bfr/knime/pmm/js/common/DepTest.java on lines 28..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void testConstructor() {
        final Dep dep = new Dep();
        assertThat(dep.name, is(nullValue()));
        assertThat(dep.origname, is(nullValue()));
Severity: Major
Found in de.bund.bfr.knime.pmm.nodes.tests/src/de/bund/bfr/knime/pmm/js/common/DepTest.java and 1 other location - About 1 hr to fix
de.bund.bfr.knime.pmm.nodes.tests/src/de/bund/bfr/knime/pmm/js/common/IndepTest.java on lines 28..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {

        GenericModelDataBackground background = new GenericModelDataBackground();

        try {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerDataModelSheetImporter.java - About 1 hr to fix

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {

        GenericModelDataBackground background = new GenericModelDataBackground();

        try {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/RAKIPSheetImporter.java - About 1 hr to fix

Method joinModels has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public Model joinModels(JsonNode modelA, JsonNode modelB, ModelClass targetModelType) throws JsonProcessingException {

        String modelAType = modelA.get("modelType").textValue();
        Map<String, Object> modelAClass = ModelClass.valueOf(modelAType).swaggerDefinition;
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/ConversionUtils.java - About 1 hr to fix

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {

        final GenericModelDataBackground background = new GenericModelDataBackground();

        try {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerConsumptionSheetImporter.java - About 1 hr to fix

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {
        final GenericModelDataBackground background = new GenericModelDataBackground();

        try {
            final Study study = retrieveStudy(sheet);
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerRiskModelSheetImporter.java - About 1 hr to fix

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {

        GenericModelDataBackground background = new GenericModelDataBackground();

        try {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerExposureSheetImporter.java - About 1 hr to fix

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {

        final GenericModelDataBackground background = new GenericModelDataBackground();

        try {
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerGenericSheetImporter.java - About 1 hr to fix

Method retrieveBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public GenericModelDataBackground retrieveBackground(Sheet sheet) {
        GenericModelDataBackground background = new GenericModelDataBackground();

        try {
            Study study = retrieveStudy(sheet);
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/src/metadata/SwaggerQraModelSheetImporter.java - About 1 hr to fix

Method eIsSet has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public boolean eIsSet(int featureID) {
        switch (featureID) {
            case MetadataPackage.STUDY__STUDY_IDENTIFIER:
                return STUDY_IDENTIFIER_EDEFAULT == null ? studyIdentifier != null : !STUDY_IDENTIFIER_EDEFAULT.equals(studyIdentifier);
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/gen/metadata/impl/StudyImpl.java - About 1 hr to fix

Method eGet has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public Object eGet(int featureID, boolean resolve, boolean coreType) {
        switch (featureID) {
            case MetadataPackage.STUDY__STUDY_IDENTIFIER:
                return getStudyIdentifier();
Severity: Minor
Found in de.bund.bfr.knime.fsklab.metadata.model/gen/metadata/impl/StudyImpl.java - About 1 hr to fix

Method saveSettingsTo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void saveSettingsTo(NodeSettingsWO settings)
            throws InvalidSettingsException {
        if (!selectionPanel.getSelectedIDs().isEmpty()) {
            set.setSelectedID(selectionPanel.getSelectedIDs().get(0));
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/secondarypredictorview/SecondaryPredictorViewNodeDialog.java - About 1 hr to fix

Method getInSchema has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private KnimeSchema getInSchema(final DataTableSpec inSpec) throws InvalidSettingsException {
        KnimeSchema result = null;
        KnimeSchema inSchema = new TimeSeriesSchema();
        boolean hasTS = false;
        try {
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/estimatedmodelwriter/EstimatedModelWriterNodeModel.java - About 1 hr to fix

Method execute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected BufferedDataTable[] execute(final BufferedDataTable[] inData,
      final ExecutionContext exec) {

    BufferedDataContainer container = exec.createDataContainer(TABLE_SPEC);
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/openfsmr/OpenFSMRConverterNodeModel.java - About 1 hr to fix

Method loadSettingsFrom has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void loadSettingsFrom(NodeSettingsRO settings, DataTableSpec[] specs) throws NotConfigurableException {
        String fileName;
        int useStartValue;
        double startElim;
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/combaseio/CombaseReaderNodeDialog.java - About 1 hr to fix

Method replaceCelsiusAndFahrenheit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private static void replaceCelsiusAndFahrenheit(KnimeTuple tuple) {
            final String CELSIUS = "°C";
            final String FAHRENHEIT = "°F";
            final String KELVIN = "K";
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/sbmlwriter/SBMLWriterNodeModel.java - About 1 hr to fix

Method saveSettingsTo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void saveSettingsTo( final NodeSettingsWO settings ) {
        try {            
            /*
              Config c = settings.addConfig("DbConfigurationUi");
Severity: Minor
Found in de.bund.bfr.knime.pmm.nodes/src/de/bund/bfr/knime/pmm/estimatedmodelreader/EstimatedModelReaderNodeModel.java - About 1 hr to fix
Severity
Category
Status
Source
Language