Sign upLogin

Sibyx/phpGPX

View on GitHub
Star
tests/CreateWaypointTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Method createWaypointFile has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
Severity: Minor
Found in tests/CreateWaypointTest.php - About 1 hr to fix

    Missing class import via use statement (line '28', column '19').
    Open

                    'time' => new \DateTime("+ 2 MINUTE")
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '22', column '19').
    Open

                    'time' => new \DateTime("+ 1 MINUTE")
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '34', column '19').
    Open

                    'time' => new \DateTime("+ 3 MINUTE")
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '40', column '19').
    Open

                    'time' => new \DateTime("+ 4 MINUTE")
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '56', column '37').
    Open

            $gpx_file->metadata->time         = new \DateTime();
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid variables with short names like $wp. Configured minimum length is 3.
    Open

            $wp = [];
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_point is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_point is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_point is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_point is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_data is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_point is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $sample_data is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $gpx_file is not named in camelCase.
    Open

        public function createWaypointFile()
    {
        $sample_data = [
            [
                'longitude' => 9.860624216140083,
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The method test_waypoints_load is not named in camelCase.
    Open

        public function test_waypoints_load()
    {
        $origFile = $this->waypoint_created_file;
        $outFile = $this->waypoint_saved_file;
    Severity: Minor
    Found in tests/CreateWaypointTest.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status