Sign upLogin

Siggg/culottes

View on GitHub
Star

Showing 624 of 624 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.web3Service
      .artifactsToContract(contractABI, this.revolutionAddress)
      .then((web3_eth_contract) => {
        this.web3_eth_contract = web3_eth_contract;
Severity: Major
Found in src/app/citizen/citizen.component.ts and 1 other location - About 1 day to fix
src/app/factory/factory.component.ts on lines 59..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 242.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    this.web3Service
      .artifactsToContract(revolutionContractABI, this.revolutionAddress)
      .then((revolutionContract) => {
        this.revolutionContract = revolutionContract;
Severity: Major
Found in src/app/factory/factory.component.ts and 1 other location - About 1 day to fix
src/app/citizen/citizen.component.ts on lines 52..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 242.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function ngOnInit has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async ngOnInit() {
    // console.log("OnInit: " + this.web3Service);
    // console.log(this);
    this.getAddress();
    this.otherRevolutions = this.web3Service.revolutions;
Severity: Major
Found in src/app/revolution/revolution.component.ts - About 5 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        this.web3Service.addSigner(this.web3_eth_contract)
      .then((contract) => {
        this.web3_eth_contract = contract;
    if (nameChange == true) {
          return contract.voteAndSetName(vote, this.address, this.name, { gasLimit: estimatedGas });
    Severity: Major
    Found in src/app/citizen/citizen.component.ts and 1 other location - About 4 hrs to fix
    src/app/factory/factory.component.ts on lines 193..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          this.web3Service.addSigner(this.factoryContract)
            .then((factoryContract) => {
              this.factoryContract = factoryContract
              return factoryContract.createRevolution(
        this.criteria,
    Severity: Major
    Found in src/app/factory/factory.component.ts and 1 other location - About 4 hrs to fix
    src/app/citizen/citizen.component.ts on lines 148..167

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function ngOnInit has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

      async ngOnInit() {
    // console.log("OnInit: " + this.web3Service);
    // console.log(this);
    this.getAddress();
    this.otherRevolutions = this.web3Service.revolutions;
    Severity: Minor
    Found in src/app/revolution/revolution.component.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File revolution.component.ts has 357 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Component, OnInit } from "@angular/core";
import { Web3Service } from "../util/web3.service";
import { Router, ActivatedRoute } from '@angular/router';

declare let require: any;
    Severity: Minor
    Found in src/app/revolution/revolution.component.ts - About 4 hrs to fix

      Function loadOtherRevolutionsThenCitizens has 108 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async loadOtherRevolutionsThenCitizens() {
    this.revolutionOwner = await this.revolutionContract.owner();
    console.log("Revolution owner: ", this.revolutionOwner);
    console.log("Getting other revolutions from this factory");
    this.factoryAddress = await this.revolutionContract.factory();
      Severity: Major
      Found in src/app/revolution/revolution.component.ts - About 4 hrs to fix

        Function onRevolutionCreate has 81 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async onRevolutionCreate() {
    let canCreate = true;
    if (this.criteria == undefined || this.criteria.length == 0) {
      this.showErrorMessageForCriteria = true;
      canCreate = false;
        Severity: Major
        Found in src/app/factory/factory.component.ts - About 3 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              function updateUIOnBlock(blockNumber) {
      component.transactionPending = false;
      component.confirmationProgress += 1; // up to 24 
      component.confirmationPercent = Math.round(100 * component.confirmationProgress / 24);
      console.log('confirmation received, with number and %: ', component.confirmationProgress, component.confirmationPercent);
          Severity: Major
          Found in src/app/citizen/citizen.component.ts and 1 other location - About 3 hrs to fix
          src/app/factory/factory.component.ts on lines 186..192

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                function updateUIOnBlock(blockNumber) {
            component.transactionPending = false;
            component.confirmationProgress += 1; // up to 24 
            component.confirmationPercent = Math.round(100 * component.confirmationProgress / 24);
            console.log('confirmation received, with number and %: ', component.confirmationProgress, component.confirmationPercent);
          Severity: Major
          Found in src/app/factory/factory.component.ts and 1 other location - About 3 hrs to fix
          src/app/citizen/citizen.component.ts on lines 134..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function ngOnInit has 71 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async ngOnInit() {
    this.getParams();
    // this.watchAccount();
    this.revolutionAddress = this
      .web3Service
          Severity: Major
          Found in src/app/factory/factory.component.ts - About 2 hrs to fix

            Function sendVote has 58 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              async sendVote(vote, weiAmount) {
    let component = this;
    component.vote = vote;
    let nameChange = false;
    let estimatedGas;
            Severity: Major
            Found in src/app/citizen/citizen.component.ts - About 2 hrs to fix

              Function loadOtherRevolutionsThenCitizens has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                private async loadOtherRevolutionsThenCitizens() {
    this.revolutionOwner = await this.revolutionContract.owner();
    console.log("Revolution owner: ", this.revolutionOwner);
    console.log("Getting other revolutions from this factory");
    this.factoryAddress = await this.revolutionContract.factory();
              Severity: Minor
              Found in src/app/revolution/revolution.component.ts - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function ngOnInit has 56 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                async ngOnInit() {
    this.getAddress();
    this.revolutionAddress = this
      .web3Service
      .revolutionAddress;
              Severity: Major
              Found in src/app/citizen/citizen.component.ts - About 2 hrs to fix

                Function cakeVote has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  async cakeVote(vote) {
    let canVote = true;
    let addressIsValid = true;
    let component = this;
                Severity: Minor
                Found in src/app/citizen/citizen.component.ts - About 1 hr to fix

                  Function onRevolutionCreate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                    async onRevolutionCreate() {
    let canCreate = true;
    if (this.criteria == undefined || this.criteria.length == 0) {
      this.showErrorMessageForCriteria = true;
      canCreate = false;
                  Severity: Minor
                  Found in src/app/factory/factory.component.ts - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
                  Severity: Minor
                  Found in karma.conf.js - About 1 hr to fix

                    Function update_culottes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def update_culottes():
    events = get_events(address)

    for event in events:
        topics = event['topics']
                    Severity: Minor
                    Found in publication/code.py - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (hashtag == null || hashtag.length == 0) {
          this.hashtagWithoutSymbol = "CulottesRevolution";
        } else if (hashtag[0] != '#') {
          this.hashtagWithoutSymbol = hashtag;
          hashtag = '#' + hashtag;
                    Severity: Major
                    Found in src/app/citizen/citizen.component.ts and 1 other location - About 1 hr to fix
                    src/app/revolution/revolution.component.ts on lines 78..86

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 61.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language