Sign upLogin

SimenB/stylint-stylish

View on GitHub
Star

Showing 9 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('should log Max Errors if provided', () => {
  stylintInstance.config.maxErrors = 1;
  stylintInstance.cache.file = path.resolve('file.styl');
  stylintInstance.cache.lineNo = 15;
  stylintInstance.cache.errs = ['', ''];
Severity: Major
Found in test.js and 1 other location - About 2 days to fix
test.js on lines 99..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 388.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('should log Max Warnings if provided', () => {
  stylintInstance.config.maxWarnings = 1;
  stylintInstance.cache.file = path.resolve('file.styl');
  stylintInstance.cache.lineNo = 15;
  stylintInstance.cache.warnings = ['', ''];
Severity: Major
Found in test.js and 1 other location - About 2 days to fix
test.js on lines 73..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 388.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function default has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

export default function(msg, done, kill) {
  if (done === 'done') {
    return doneHandler.call(this, kill);
  }
Severity: Minor
Found in stylish.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (errs > 0) {
    output += `  ${logSymbols.error}  ${errs} ${errs > 1 ? 'errors' : 'error'}`;

    if (typeof maxErrors === 'number') {
      output += ` (Max Errors: ${maxErrors})`;
Severity: Major
Found in stylish.js and 1 other location - About 2 hrs to fix
stylish.js on lines 37..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (warns > 0) {
    output += `  ${logSymbols.warning}  ${warns} ${
      warns > 1 ? 'warnings' : 'warning'
    }`;
Severity: Major
Found in stylish.js and 1 other location - About 2 hrs to fix
stylish.js on lines 27..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File test.js has 261 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable no-param-reassign */
/* eslint-env jest */

import stripAnsi from 'strip-ansi';
import logSymbols from 'log-symbols';
Severity: Minor
Found in test.js - About 2 hrs to fix

    Function default has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function(msg, done, kill) {
  if (done === 'done') {
    return doneHandler.call(this, kill);
  }
    Severity: Minor
    Found in stylish.js - About 1 hr to fix

      Function createSummary has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function createSummary(errs, warns, total, maxErrors, maxWarnings) {
  if (total === 0) {
    return 'No violations';
  }
      Severity: Minor
      Found in stylish.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createSummary has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function createSummary(errs, warns, total, maxErrors, maxWarnings) {
      Severity: Minor
      Found in stylish.js - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language