Sign upLogin

SimonBaeumer/goss

View on GitHub
Star
add.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Add.AddResource has 110 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (a *Add) AddResource(fileName string, gossConfig GossConfig, resourceName, key string, config util.Config) error {
    // Need to figure out a good way to refactor this
    switch resourceName {
    case "addr":
        res, err := gossConfig.Addrs.AppendSysResource(key, a.Sys, config)
Severity: Major
Found in add.go - About 3 hrs to fix

    Method Add.AddResource has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func (a *Add) AddResource(fileName string, gossConfig GossConfig, resourceName, key string, config util.Config) error {
    // Need to figure out a good way to refactor this
    switch resourceName {
    case "addr":
        res, err := gossConfig.Addrs.AppendSysResource(key, a.Sys, config)
    Severity: Minor
    Found in add.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Add.AutoAddResource has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func (a *Add) AutoAddResource(fileName string, gossConfig GossConfig, key string) error {
    // file
    if strings.Contains(key, "/") {
        if res, _, ok := gossConfig.Files.AppendSysResourceIfExists(key, a.Sys); ok == true {
            a.resourcePrint(fileName, res)
    Severity: Minor
    Found in add.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status