Sign upLogin

SimpliField/jsub

View on GitHub
Star

Showing 7 of 7 total issues

Function checkExpression has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function checkExpression(errors, conditions, expression) {
  var expressionErrors = [];

  debug('Checking expression:', expression);
  // Check alls conditions
Severity: Minor
Found in src/index.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkExpression has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function checkExpression(errors, conditions, expression) {
  var expressionErrors = [];

  debug('Checking expression:', expression);
  // Check alls conditions
Severity: Major
Found in src/index.js - About 3 hrs to fix

    Function checkConditionKey has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function checkConditionKey(condition, expression, errors, property) {
  // Simple value based condition
  if (
    -1 !== ['boolean', 'string', 'number'].indexOf(typeof condition[property])
  ) {
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function checkConditionKey has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function checkConditionKey(condition, expression, errors, property) {
  // Simple value based condition
  if (
    -1 !== ['boolean', 'string', 'number'].indexOf(typeof condition[property])
  ) {
      Severity: Minor
      Found in src/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        } else if ('CallExpression' === expression.type) {
    errors = checkExpression(errors, conditions, expression.callee);
    errors = expression.arguments.reduce(function(errors, expression) {
      return errors.concat(checkExpression(errors, conditions, expression));
    }, errors);
      Severity: Major
      Found in src/index.js and 1 other location - About 1 hr to fix
      src/index.js on lines 75..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        } else if ('NewExpression' === expression.type) {
    errors = checkExpression(errors, conditions, expression.callee);
    errors = expression.arguments.reduce(function(errors, expression) {
      return errors.concat(checkExpression(errors, conditions, expression));
    }, errors);
      Severity: Major
      Found in src/index.js and 1 other location - About 1 hr to fix
      src/index.js on lines 83..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

          if (!(condition[property] instanceof Function)) {
      throw new YError(
        'E_BAD_EXPRESSION_CHECKER',
        property,
        condition[property]
      Severity: Major
      Found in src/index.js - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language