SinSquare/silex-doctrine-cache-provider

View on GitHub
src/Sins/Cache/DoctrineCacheServiceProvider.php

Summary

Maintainability
D
2 days
Test Coverage

Method register has 149 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function register(Container $app)
    {
        //initialize and validate options
        $app['doctrine.cache.options.initializer'] = $app->protect(function () use ($app) {
            static $initialized = false;
Severity: Major
Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 5 hrs to fix

    Avoid too many return statements within this method.
    Open

                return new ApcuCache();
    Severity: Major
    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new ChainCache($caches);
      Severity: Major
      Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $caches;
        Severity: Major
        Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return new FilesystemCache($directory, $extension, $umask);
          Severity: Major
          Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return new \Memcache();
            Severity: Major
            Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $app[$cacheFactoryKey]($cacheOptions);
              Severity: Major
              Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $cache;
                Severity: Major
                Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $app['doctrine.cache.locator']($name, $options);
                    Severity: Major
                    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return new ArrayCache();
                      Severity: Major
                      Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return $app['doctrine.cache.'.$name];
                        Severity: Major
                        Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return new \Memcached();
                          Severity: Major
                          Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                return $cache;
                            Severity: Major
                            Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return new VoidCache();
                              Severity: Major
                              Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return $cache;
                                Severity: Major
                                Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return new PhpFileCache($directory, $extension, $umask);
                                  Severity: Major
                                  Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 30 mins to fix

                                    Function register has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function register(Container $app)
                                        {
                                            //initialize and validate options
                                            $app['doctrine.cache.options.initializer'] = $app->protect(function () use ($app) {
                                                static $initialized = false;
                                    Severity: Minor
                                    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            $app['doctrine.cache.factory.phpfile'] = $app->protect(function ($cacheOptions) {
                                    
                                                if (empty($cacheOptions['directory'])) {
                                                    throw new \RuntimeException('FilesystemCache directory not defined');
                                                }
                                    Severity: Major
                                    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php and 1 other location - About 2 hrs to fix
                                    src/Sins/Cache/DoctrineCacheServiceProvider.php on lines 111..122

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 122.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            $app['doctrine.cache.factory.filesystem'] = $app->protect(function ($cacheOptions) {
                                                
                                                if (empty($cacheOptions['directory'])) {
                                                    throw new \RuntimeException('FilesystemCache directory not defined');
                                                }
                                    Severity: Major
                                    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php and 1 other location - About 2 hrs to fix
                                    src/Sins/Cache/DoctrineCacheServiceProvider.php on lines 162..173

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 122.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            $app['doctrine.cache.factory.memcached'] = $app->protect(function ($cacheOptions) {
                                                if (empty($cacheOptions['host']) || empty($cacheOptions['port'])) {
                                                    throw new \RuntimeException('Host and port options need to be specified for memcached cache');
                                                }
                                    
                                    
                                    Severity: Major
                                    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php and 1 other location - About 1 hr to fix
                                    src/Sins/Cache/DoctrineCacheServiceProvider.php on lines 128..141

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 113.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            $app['doctrine.cache.factory.memcache'] = $app->protect(function ($cacheOptions) {
                                                if (empty($cacheOptions['host']) || empty($cacheOptions['port'])) {
                                                    throw new \RuntimeException('Host and port options need to be specified for memcache cache');
                                                }
                                    
                                    
                                    Severity: Major
                                    Found in src/Sins/Cache/DoctrineCacheServiceProvider.php and 1 other location - About 1 hr to fix
                                    src/Sins/Cache/DoctrineCacheServiceProvider.php on lines 147..160

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 113.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    There are no issues that match your filters.

                                    Category
                                    Status