Showing 3 of 3 total issues
Function _query_conditions has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def _query_conditions(args) -> dict:
query_conditions = {}
for query_param in ("city", "district", "phone", "house_type", "lessor_gender"):
if args[query_param]:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function save_all_house_url has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def save_all_house_url(
self, output_file: str, city_id: int = 1, page_limit: int = 3
):
"""parse urls from housing website and save as csv file
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _valid_token has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def _valid_token(token: str, user_role: str):
account = Account.objects(token=token).first()
# 1. account exist
if not account:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"