Sign upLogin

Sleepness/UberTranslationAdminBundle

View on GitHub
Star

Showing 10 of 10 total issues

Function buildByDomain has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function buildByDomain($domain)
    {
        $locales = $this->supportedLocales;
        foreach ($locales as $key => $locale) {
            if (!preg_match('/^[a-z]{2}_[a-zA-Z]{2}$|[a-z]{2}/', $locale)) {
Severity: Minor
Found in Frontend/MemcachedMessagesFrontendCatalogue.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildByText has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function buildByText($text)
    {
        $locales = $this->supportedLocales;
        foreach ($locales as $key => $locale) {
            if (!preg_match('/^[a-z]{2}_[a-zA-Z]{2}$|[a-z]{2}/', $locale)) {
Severity: Minor
Found in Frontend/MemcachedMessagesFrontendCatalogue.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildByKey has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function buildByKey($keyYml)
    {
        $locales = $this->supportedLocales;
        foreach ($locales as $key => $locale) {
            if (!preg_match('/^[a-z]{2}_[a-zA-Z]{2}$|[a-z]{2}/', $locale)) {
Severity: Minor
Found in Frontend/MemcachedMessagesFrontendCatalogue.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAll has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAll()
    {
        $locales = $this->supportedLocales;
        foreach ($locales as $key => $locale) {
            if (!preg_match('/^[a-z]{2}_[a-zA-Z]{2}$|[a-z]{2}/', $locale)) {
Severity: Minor
Found in Frontend/MemcachedMessagesFrontendCatalogue.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if ($translation_form_locale.val() != definedLocale) {
            $changed_locale.show();
            $("#edited_locale").text($("#translation_form_locale").val());
        }
Severity: Major
Found in Resources/public/js/jquery.ubertranslation.js and 2 other locations - About 55 mins to fix
Resources/public/js/jquery.ubertranslation.js on lines 52..55
Resources/public/js/jquery.ubertranslation.js on lines 60..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if ($translation_form_domain.val() != definedDomain) {
            $changed_domain.show();
            $("#edited_domain").text($("#translation_form_domain").val());
        }
Severity: Major
Found in Resources/public/js/jquery.ubertranslation.js and 2 other locations - About 55 mins to fix
Resources/public/js/jquery.ubertranslation.js on lines 52..55
Resources/public/js/jquery.ubertranslation.js on lines 56..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if ($translation_form_translation.val() != definedMessage) {
            $changed_translation.show();
            $("#edited_translation").text($("#translation_form_translation").val());
        }
Severity: Major
Found in Resources/public/js/jquery.ubertranslation.js and 2 other locations - About 55 mins to fix
Resources/public/js/jquery.ubertranslation.js on lines 56..59
Resources/public/js/jquery.ubertranslation.js on lines 60..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method replace has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function replace($_key, $_locale, $_domain, $formLocale, $formDomain, $formMessage)
Severity: Minor
Found in Frontend/MemcachedMessagesFrontendCatalogue.php - About 45 mins to fix

    Function createAction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createAction(Request $request)
    {
        $model = new TranslationModel();
        $form = $this->createForm(new TranslationMessageType(), $model);
        $form->handleRequest($request);
    Severity: Minor
    Found in Controller/TranslationController.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildByLocale has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function buildByLocale($locale)
    {
        if (!preg_match('/^[a-z]{2}_[a-zA-Z]{2}$|[a-z]{2}/', $locale)) {
            return $this->preparedTranslations;
        }
    Severity: Minor
    Found in Frontend/MemcachedMessagesFrontendCatalogue.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language