Sign upLogin

SmashKs/OneShoot

View on GitHub
Star
presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt

Summary

Maintainability
D
1 day
Test Coverage

Method scaleBitmap has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

    private fun scaleBitmap(data: ByteArray) {
        BitmapFactory.decodeByteArray(data, 0, data.size).also { bmp ->
            selectedRectF.apply {
                // Round the x, y, width, and height for avoiding the range is over than bitmap size.
                var roundWidth = (x + w).let { if (it > bmp.width) bmp.width - x else w }
Severity: Minor
Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method showSelectionDialog has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

    //region Showing From ViewModel
    private fun showSelectionDialog(bitmap: Bitmap) {
        selectionDialog = QuickDialogFragment.Builder(this) {
            var debouncing = false
Severity: Minor
Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method showSelectionDialog has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    //region Showing From ViewModel
    private fun showSelectionDialog(bitmap: Bitmap) {
        selectionDialog = QuickDialogFragment.Builder(this) {
            var debouncing = false
Severity: Minor
Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt - About 1 hr to fix

    Method rendered has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        //region Base Fragment
    override fun rendered(savedInstanceState: Bundle?) {
        cv_camera.apply {
            setLifecycleOwner(this@TakeAPicFragment)
            clearCameraListeners()
    Severity: Minor
    Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  onStartBlock = {
                val (width, height) = requireNotNull(it.activity?.displayPixels())
                val realWidth = width * DIALOG_FRAGMENT_WIDTH_RATIO
                val realHeight = height * DIALOG_FRAGMENT_HEIGHT_RATIO
                it.dialog?.window?.apply {
      Severity: Major
      Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt and 1 other location - About 2 hrs to fix
      presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/AnalyzeFragment.kt on lines 94..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 169.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      var roundHeight = (y + h).let { if (it > bmp.height) bmp.height - y else h }
      Severity: Minor
      Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt and 1 other location - About 50 mins to fix
      presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt on lines 273..273

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      var roundWidth = (x + w).let { if (it > bmp.width) bmp.width - x else w }
      Severity: Minor
      Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt and 1 other location - About 50 mins to fix
      presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt on lines 274..274

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      val roundX = x.takeIf { 0 < it } ?: let { roundWidth = w + x; 0 }
      Severity: Minor
      Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt and 1 other location - About 45 mins to fix
      presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt on lines 276..276

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      val roundY = y.takeIf { 0 < it } ?: let { roundHeight = h + y; 0 }
      Severity: Minor
      Found in presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt and 1 other location - About 45 mins to fix
      presentation/src/main/java/smash/ks/com/oneshoot/features/photograph/TakeAPicFragment.kt on lines 275..275

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status