Smile-SA/elasticsuite

View on GitHub

Showing 1,375 of 1,375 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        \Magento\Backend\Block\Template\Context $context,
        \Smile\ElasticsuiteAnalytics\Model\Report\Context $reportContext,
        \Smile\ElasticsuiteTracker\Model\IndexManager $indexManager,
        \Magento\Framework\Serialize\Serializer\Json $jsonSerializer,
        array $data = []

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            \Smile\ElasticsuiteCore\Search\Request\Aggregation\AggregationFactory $aggregationFactory,
            \Smile\ElasticsuiteCore\Search\Request\Aggregation\MetricFactory $metricFactory,
            \Smile\ElasticsuiteCore\Search\Request\Aggregation\PipelineFactory $pipelineFactory,
            \Smile\ElasticsuiteCore\Search\Request\Query\QueryFactory $queryFactory,
            \Smile\ElasticsuiteAnalytics\Helper\Data $helper

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              \Magento\Backend\App\Action\Context $context,
              PageFactory $resultPageFactory,
              \Magento\Framework\Registry $coreRegistry,
              ThesaurusRepositoryInterface $thesaurusRepository,
              ThesaurusFactory $thesaurusFactory

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                \Magento\Backend\Block\Context $context,
                \Magento\Framework\Data\FormFactory $formFactory,
                \Magento\Framework\Registry $registry,
                ReadHandler $readHandler,
                array $data = []

          Method resolve has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
          Severity: Minor
          Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Products.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    FileResolverInterface $fileResolver,
                    ConverterInterface $converter,
                    SchemaLocator $schemaLocator,
                    DomFactory $domFactory,
                    $fileName = self::FILE_NAME

              Method resolve has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        \Smile\ElasticsuiteCore\Search\Request\Builder $searchRequestBuilder,
                        Context $context,
                        array $aggregationProviders = [],
                        array $queryProviders = [],
                        $containerName = 'tracking_log_event'
                Severity: Minor
                Found in src/module-elasticsuite-analytics/Model/Report/SearchRequestBuilder.php - About 35 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          \Magento\Framework\View\Element\Template\Context $context,
                          \Magento\Framework\Json\Helper\Data $jsonHelper,
                          \Smile\ElasticsuiteTracker\Helper\Data $trackerHelper,
                          \Magento\Framework\Registry $registry,
                          array $data = []
                  Severity: Minor
                  Found in src/module-elasticsuite-tracker/Block/Variables/AbstractBlock.php - About 35 mins to fix

                    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            DataCheckResultFactory $checkResultFactory,
                            Builder $searchRequestBuilder,
                            QueryFactory $queryFactory,
                            SearchEngineInterface $searchEngine,
                            ?DataFixerInterface $dataFixer = null

                      Method aroundLoad has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function aroundLoad(FlatResource $categoryResource, \Closure $proceed, $category, $value, $field = null)

                        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                Data $catalogSearchHelper,
                                CustomerTrackingServiceInterface $service,
                                CookieManagerInterface $cookieManager,
                                TrackerHelper $trackerHelper,
                                PageTypeConfig $pageTypeConfig
                        Severity: Minor
                        Found in src/module-elasticsuite-tracker/Observer/TrackRedirectIfOneResult.php - About 35 mins to fix

                          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  Context $layerContext,
                                  Resolver $layerResolver,
                                  FilterableAttributesListFactory $filterableAttributesListFactory,
                                  FilterListFactory $filterListFactory,
                                  $filtersList = []

                            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    ActionFactory $actionFactory,
                                    ManagerInterface $eventManager,
                                    StoreManagerInterface $storeManager,
                                    Url $urlModel,
                                    VirtualCategoryRoot $virtualCategoryRoot
                            Severity: Minor
                            Found in src/module-elasticsuite-virtual-category/Controller/Router.php - About 35 mins to fix

                              Method resolve has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      Field $field,
                                      $context,
                                      ResolveInfo $info,
                                      array $value = null,
                                      array $args = null
                              Severity: Minor
                              Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Aggregations.php - About 35 mins to fix

                                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        \Magento\Framework\Indexer\IndexerRegistry $indexerRegistry,
                                        FullIndexer $fullIndexer,
                                        \Smile\ElasticsuiteVirtualCategory\Model\ResourceModel\Category\Product\Position $saveHandler,
                                        \Magento\Framework\Json\Helper\Data $jsonHelper,
                                        \Magento\Framework\Message\ManagerInterface $messageManager

                                  Method combineSynonyms has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      private function combineSynonyms($queryText, $synonymByPositions, $maxRewrites, $substitutions = 0, $offset = 0)
                                  Severity: Minor
                                  Found in src/module-elasticsuite-thesaurus/Model/Index.php - About 35 mins to fix

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            if ($this->missing === null) {
                                                $this->missing = $direction == self::SORT_ASC ? self::MISSING_LAST : self::MISSING_FIRST;
                                            }
                                    src/module-elasticsuite-core/Search/Request/SortOrder/Standard.php on lines 62..64

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 42.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            $result = $this->layerFormatter->buildLayer(
                                                $label,
                                                \count($categoryIds),
                                                self::$bucketMap[self::CATEGORY_BUCKET]['request_name']
                                            );
                                    src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Category.php on lines 152..156

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 42.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            $result = $this->layerFormatter->buildLayer(
                                                $label,
                                                \count($categoryIds),
                                                self::$bucketMap[self::CATEGORY_BUCKET]['request_name']
                                            );
                                    src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/CategoryUid.php on lines 163..167

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 42.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language