Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star

Showing 1,375 of 1,375 total issues

Argument 1 (attributeCollection) is \Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection but \Smile\ElasticsuiteCatalog\Model\ResourceModel\Eav\Indexer\Fulltext\Datasource\AbstractAttributeData::addIndexedFilterToAttributeCollection() takes \Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection defined at /code/src/module-elasticsuite-catalog/Model/ResourceModel/Eav/Indexer/Fulltext/Datasource/AbstractAttributeData.php:75
Open

        $this->resourceModel->addIndexedFilterToAttributeCollection($attributeCollection);
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Eav/Indexer/Fulltext/Datasource/AbstractAttributeData.php by phan

Doc-block of $connection in __construct is phpdoc param type \Magento\Framework\DB\Adapter\AdapterInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\DB\Adapter\AdapterInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\DB\Adapter\AdapterInterface               $connection              Db Connection.
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/ResourceModel/Product/Fulltext/Collection.php by phan

Returning type \Magento\Catalog\Api\Data\CategoryInterface but afterGetCurrentCategory() is declared to return \Magento\Catalog\Model\Layer\Category
Open

        return $category;
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Layer/CategoryPlugin.php by phan

syntax error, unexpected 'bool' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)
Open

    private bool $hasKnnFields = false;
Severity: Critical
Found in src/module-elasticsuite-core/Index/Mapping.php by phan

Doc-block of $cache in __construct is phpdoc param type \Magento\Framework\App\CacheInterface which is not a permitted replacement of the nullable param type ?\Magento\Framework\App\CacheInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param \Magento\Framework\App\CacheInterface $cache              Cache interface
Severity: Minor
Found in src/module-elasticsuite-core/Model/ProductMetadata.php by phan

Assigning \Magento\Framework\Search\Response\Aggregation to property but \Smile\ElasticsuiteCore\Search\Adapter\Elasticsuite\Response\QueryResponse->aggregations is \Magento\Framework\Api\Search\AggregationInterface
Open

        $this->aggregations = $aggregationFactory->create($aggregations);
Severity: Minor
Found in src/module-elasticsuite-core/Search/Adapter/Elasticsuite/Response/QueryResponse.php by phan

Doc-block of $nestedFilter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $nestedFilter   Nested filter for the bucket.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/Histogram.php by phan

Doc-block of $nestedFilter in __construct is phpdoc param type \Smile\ElasticsuiteCore\Search\Request\QueryInterface which is not a permitted replacement of the nullable param type ?\Smile\ElasticsuiteCore\Search\Request\QueryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param QueryInterface      $nestedFilter Nested filter for the bucket.
Severity: Minor
Found in src/module-elasticsuite-core/Search/Request/Aggregation/Bucket/QueryGroup.php by phan

Possibly zero references to use statement for classlike/namespace MetricInterface (\Smile\ElasticsuiteCore\Search\Request\MetricInterface)
Open

use Smile\ElasticsuiteCore\Search\Request\MetricInterface;
Severity: Minor
Found in src/module-elasticsuite-analytics/Model/Search/Usage/Kpi/ConversionRates/AggregationProvider.php by phan

Call to method getFrontendInput on non-class type null
Open

            $result[$attributeCode]['frontend_input'] = $attribute->getFrontendInput();
Severity: Critical
Found in src/module-elasticsuite-catalog-graph-ql/DataProvider/Product/LayeredNavigation/Builder/Attribute.php by phan

Argument 1 (args) is ?array but \Smile\ElasticsuiteCatalogGraphQl\Model\Resolver\Layer\Filter\ViewMore::validateArgs() takes array defined at /code/src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Layer/Filter/ViewMore.php:105
Open

        $this->validateArgs($args);
Severity: Minor
Found in src/module-elasticsuite-catalog-graph-ql/Model/Resolver/Layer/Filter/ViewMore.php by phan

Class \Smile\ElasticsuiteCatalogOptimizer\Model\ResourceModel\Optimizer\Collection was passed to foreach, but it does not extend Traversable and none of its declared properties are accessible from this context. (This check excludes dynamic properties)
Open

        foreach ($optimizers as $optimizer) {
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer/Functions/Provider/DefaultProvider.php by phan

Argument 1 (condition) is \Magento\Framework\Api\ExtensibleDataInterface|\Smile\ElasticsuiteCatalogRule\Api\Data\ConditionInterface but \Smile\ElasticsuiteCatalogRule\Model\Rule::dataModelToArray() takes \Smile\ElasticsuiteCatalogRule\Model\Data\Condition defined at /code/src/module-elasticsuite-catalog-rule/Model/Rule.php:181
Open

                $conditions[] = $this->dataModelToArray($subCondition, $key);
Severity: Minor
Found in src/module-elasticsuite-catalog-rule/Model/Rule.php by phan

Doc-block of $scopeConfig in __construct contains phpdoc param type \Magento\Framework\ObjectManagerInterface which is incompatible with the param type \Magento\Framework\App\Config\ScopeConfigInterface declared in the signature
Open

     * @param \Magento\Framework\ObjectManagerInterface $scopeConfig    Configuration.
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Product/Indexer/Fulltext/Action/FullFactory.php by phan

Saw a token Phan may have failed to parse after '* @return array()': after array, saw '('
Open

     * @return array()
Severity: Info
Found in src/module-elasticsuite-catalog/Model/ResourceModel/Product/Fulltext/Collection.php by phan

Returning type \Magento\Catalog\Api\Data\CategoryAttributeInterface|null but getUseNameInSearchAttribute() is declared to return \Magento\Eav\Model\Entity\Attribute\AbstractAttribute
Open

        return $this->useNameInSearchAttribute;
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/ResourceModel/Product/Indexer/Fulltext/Datasource/CategoryData.php by phan

Assigning null to property but \Smile\ElasticsuiteCatalog\Model\ResourceModel\Product\Indexer\Fulltext\Datasource\PriceData->dimensions is array
Open

        $this->dimensions = null;
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/ResourceModel/Product/Indexer/Fulltext/Datasource/PriceData.php by phan

Argument 4 (spellingType) is 1 but \Smile\ElasticsuiteCore\Search\Request\Query\Builder::createQuery() takes string defined at /code/src/module-elasticsuite-core/Search/Request/Query/Builder.php:75
Open

            SpellcheckerInterface::SPELLING_TYPE_EXACT
Severity: Minor
Found in src/module-elasticsuite-catalog/Model/Search/Preview.php by phan

Possibly zero references to use statement for classlike/namespace QueryBuilder (\Smile\ElasticsuiteCore\Search\Request\Query\Builder)
Open

use Smile\ElasticsuiteCore\Search\Request\Query\Builder as QueryBuilder;
Severity: Minor
Found in src/module-elasticsuite-catalog/Plugin/Ui/Category/Form/DataProviderPlugin.php by phan

Argument 3 (query) is \Magento\Framework\Search\Request\QueryInterface|\Smile\ElasticsuiteCore\Search\Request\QueryInterface|string but \Smile\ElasticsuiteCatalog\Search\Request\Product\Aggregation\Provider\FilterableAttributes\Modifier\Coverage::getCoverageRates() takes null defined at /code/src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Coverage.php:119
Open

        $coverageRates      = $this->getCoverageRates($storeId, $requestName, $query, $filters, $queryFilters);
Severity: Minor
Found in src/module-elasticsuite-catalog/Search/Request/Product/Aggregation/Provider/FilterableAttributes/Modifier/Coverage.php by phan
Severity
Category
Status
Source
Language