Sign upLogin

Smile-SA/elasticsuite

View on GitHub
Star
src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Preview.php

Summary

Maintainability
B
4 hrs
Test Coverage

Preview has 12 functions (exceeds 10 allowed). Consider refactoring.
Open

class Preview extends Action
{
    /**
     * @var \Smile\ElasticsuiteCatalogOptimizer\Model\Optimizer\PreviewFactory
     */
Severity: Minor
Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Preview.php - About 2 hrs to fix

    Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Context $context,
        PreviewFactory $previewModelFactory,
        CategoryRepositoryInterface $categoryRepository,
        OptimizerInterfaceFactory $optimizerFactory,
        ContainerConfigurationFactory $containerConfigFactory,
    Severity: Major
    Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Preview.php - About 1 hr to fix

      Function updateSearchContext has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function updateSearchContext($storeId, $category, $queryText)
    {
        $this->searchContext->setStoreId($storeId);

        if ((string) $queryText !== '') {
      Severity: Minor
      Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Preview.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Returning type ?string but getQueryText() is declared to return string
      Open

              return $queryText;
      Severity: Minor
      Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Preview.php by phan

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public function execute()
    {
        $responseData = $this->getPreviewObject()->getData();
        $json         = $this->jsonHelper->jsonEncode($responseData);
      Severity: Minor
      Found in src/module-elasticsuite-catalog-optimizer/Controller/Adminhtml/Optimizer/Preview.php and 1 other location - About 40 mins to fix
      src/module-elasticsuite-virtual-category/Controller/Adminhtml/Category/Virtual/Preview.php on lines 68..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status